SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

hw/isa/piix3: Prefer pci_address_space() over get_system_memory()

Browse Source 
get_system_memory() accesses global state while pci_address_space() uses
whatever has been passed to the device instance, so avoid the global.
Moreover, PIIX4 uses pci_address_space() here as well.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-Id: <20221022150508.26830-7-shentey@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
This commit is contained in:
Bernhard Beschow 2022-10-22 17:04:31 +02:00 committed by Philippe Mathieu-Daudé
parent a1b05751fa
commit 57654b8e98
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/isa/piix3.c
View File

@ -301,7 +301,7 @@ static void pci_piix3_realize(PCIDevice *dev, Error **errp)
PIIX3State *d = PIIX3_PCI_DEVICE(dev); PIIX3State *d = PIIX3_PCI_DEVICE(dev);
ISABus *isa_bus; ISABus *isa_bus;
isa_bus = isa_bus_new(DEVICE(d), get_system_memory(), isa_bus = isa_bus_new(DEVICE(d), pci_address_space(dev),
pci_address_space_io(dev), errp); pci_address_space_io(dev), errp);
if (!isa_bus) { if (!isa_bus) {
return; return;