SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

ide: avoid referencing NULL dev in rotational rate setting

Browse Source 
The 'dev' variable can be NULL when the guest OS calls identify on an IDE
unit that does not have a drive attached to it.

Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Message-id: 20171020091403.1479-1-berrange@redhat.com
Signed-off-by: John Snow <jsnow@redhat.com>
This commit is contained in:
Daniel P. Berrange 2017-10-20 10:14:03 +01:00 committed by John Snow
parent 2585c67983
commit 96f43c2b0a
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hw/ide/core.c
View File

@ -208,7 +208,9 @@ static void ide_identify(IDEState *s)
if (dev && dev->conf.discard_granularity) {
put_le16(p + 169, 1); /* TRIM support */
}
put_le16(p + 217, dev->rotation_rate); /* Nominal media rotation rate */
if (dev) {
put_le16(p + 217, dev->rotation_rate); /* Nominal media rotation rate */
}
ide_identify_size(s);
s->identify_set = 1;