SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

qemu-ga: ga_get_fd_handle(): abort if fd_counter overflows

Browse Source 
Today we reset fd_counter if it wraps, but it's better to abort()
instead, as fd_counter should never reach INT64_MAX.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>

*fixed typo: s/resonable/reasonable/

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
This commit is contained in:
Luiz Capitulino 2013-03-22 16:31:07 -04:00 committed by Michael Roth
parent 9481ecd737
commit ce7f7cc271
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
qga/main.c
View File

@ -889,9 +889,13 @@ int64_t ga_get_fd_handle(GAState *s, Error **errp)
g_assert(!ga_is_frozen(s)); g_assert(!ga_is_frozen(s));
handle = s->pstate.fd_counter++; handle = s->pstate.fd_counter++;
if (s->pstate.fd_counter < 0) {
s->pstate.fd_counter = 0; /* This should never happen on a reasonable timeframe, as guest-file-open
* would have to be issued 2^63 times */
if (s->pstate.fd_counter == INT64_MAX) {
abort();
} }
if (!write_persistent_state(&s->pstate, s->pstate_filepath)) { if (!write_persistent_state(&s->pstate, s->pstate_filepath)) {
error_setg(errp, "failed to commit persistent state to disk"); error_setg(errp, "failed to commit persistent state to disk");
} }