SYS-OSS/FRET-qemu
4
0
Fork 0
Code Issues Pull Requests Projects Releases Wiki Activity

eepro100: Use tx.status

Browse Source 
There is no need for a local variable "status".
Using tx.status makes it clearer which status
is addressed.

Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Stefan Weil 2010-03-02 22:37:56 +01:00 committed by Michael S. Tsirkin
parent cc02c66cc8
commit ec1d02d8de
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hw/eepro100.c
View File

@ -903,10 +903,10 @@ static void action_command(EEPRO100State *s)
for (;;) { for (;;) {
s->cb_address = s->cu_base + s->cu_offset; s->cb_address = s->cu_base + s->cu_offset;
cpu_physical_memory_read(s->cb_address, (uint8_t *)&s->tx, sizeof(s->tx)); cpu_physical_memory_read(s->cb_address, (uint8_t *)&s->tx, sizeof(s->tx));
uint16_t status = le16_to_cpu(s->tx.status);
uint16_t command = le16_to_cpu(s->tx.command); uint16_t command = le16_to_cpu(s->tx.command);
s->tx.status = le16_to_cpu(s->tx.status);
logout("val=(cu start), status=0x%04x, command=0x%04x, link=0x%08x\n", logout("val=(cu start), status=0x%04x, command=0x%04x, link=0x%08x\n",
status, command, s->tx.link); s->tx.status, command, s->tx.link);
bool bit_el = ((command & COMMAND_EL) != 0); bool bit_el = ((command & COMMAND_EL) != 0);
bool bit_s = ((command & COMMAND_S) != 0); bool bit_s = ((command & COMMAND_S) != 0);
bool bit_i = ((command & COMMAND_I) != 0); bool bit_i = ((command & COMMAND_I) != 0);
@ -950,7 +950,7 @@ static void action_command(EEPRO100State *s)
break; break;
} }
/* Write new status. */ /* Write new status. */
stw_phys(s->cb_address, status | STATUS_C | (success ? STATUS_OK : 0)); stw_phys(s->cb_address, s->tx.status | STATUS_C | (success ? STATUS_OK : 0));
if (bit_i) { if (bit_i) {
/* CU completed action. */ /* CU completed action. */
eepro100_cx_interrupt(s); eepro100_cx_interrupt(s);