The MachineClass uses an inverted logic (inherited from the PC machines [*]) to create the chardev backends for the default devices (see commits 998bbd74b9d..aa40fc9c964 and ac33f8fad14). As the none-machine doesn't have any hardware device, it is pointless to initialize chardev backends. Fix by setting the 'no_defaults' bits in its MachineClass. Suggested-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Thomas Huth <thuth@redhat.com> Message-Id: <20200624105611.1049-1-f4bug@amsat.org> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
		
			
				
	
	
		
			61 lines
		
	
	
		
			1.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			61 lines
		
	
	
		
			1.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * Empty machine
 | 
						|
 *
 | 
						|
 * Copyright IBM, Corp. 2012
 | 
						|
 *
 | 
						|
 * Authors:
 | 
						|
 *  Anthony Liguori   <aliguori@us.ibm.com>
 | 
						|
 *
 | 
						|
 * This work is licensed under the terms of the GNU GPL, version 2 or later.
 | 
						|
 * See the COPYING file in the top-level directory.
 | 
						|
 *
 | 
						|
 */
 | 
						|
 | 
						|
#include "qemu/osdep.h"
 | 
						|
#include "qemu/error-report.h"
 | 
						|
#include "hw/boards.h"
 | 
						|
#include "sysemu/sysemu.h"
 | 
						|
#include "exec/address-spaces.h"
 | 
						|
#include "hw/core/cpu.h"
 | 
						|
 | 
						|
static void machine_none_init(MachineState *mch)
 | 
						|
{
 | 
						|
    CPUState *cpu = NULL;
 | 
						|
 | 
						|
    /* Initialize CPU (if user asked for it) */
 | 
						|
    if (mch->cpu_type) {
 | 
						|
        cpu = cpu_create(mch->cpu_type);
 | 
						|
        if (!cpu) {
 | 
						|
            error_report("Unable to initialize CPU");
 | 
						|
            exit(1);
 | 
						|
        }
 | 
						|
    }
 | 
						|
 | 
						|
    /* RAM at address zero */
 | 
						|
    if (mch->ram) {
 | 
						|
        memory_region_add_subregion(get_system_memory(), 0, mch->ram);
 | 
						|
    }
 | 
						|
 | 
						|
    if (mch->kernel_filename) {
 | 
						|
        error_report("The -kernel parameter is not supported "
 | 
						|
                     "(use the generic 'loader' device instead).");
 | 
						|
        exit(1);
 | 
						|
    }
 | 
						|
}
 | 
						|
 | 
						|
static void machine_none_machine_init(MachineClass *mc)
 | 
						|
{
 | 
						|
    mc->desc = "empty machine";
 | 
						|
    mc->init = machine_none_init;
 | 
						|
    mc->max_cpus = 1;
 | 
						|
    mc->default_ram_size = 0;
 | 
						|
    mc->default_ram_id = "ram";
 | 
						|
    mc->no_serial = 1;
 | 
						|
    mc->no_parallel = 1;
 | 
						|
    mc->no_floppy = 1;
 | 
						|
    mc->no_cdrom = 1;
 | 
						|
    mc->no_sdcard = 1;
 | 
						|
}
 | 
						|
 | 
						|
DEFINE_MACHINE("none", machine_none_machine_init)
 |