Lukas Straub 3b78420bb1 replication: Properly attach children
The replication driver needs access to the children block-nodes of
it's child so it can issue bdrv_make_empty() and bdrv_co_pwritev()
to manage the replication. However, it does this by directly copying
the BdrvChilds, which is wrong.

Fix this by properly attaching the block-nodes with
bdrv_attach_child() and requesting the required permissions.

This ultimatively fixes a potential crash in replication_co_writev(),
because it may write to s->secondary_disk if it is in state
BLOCK_REPLICATION_FAILOVER_FAILED, without requesting write
permissions first. And now the workaround in
secondary_do_checkpoint() can be removed.

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Message-Id: <5d0539d729afb8072d0d7cde977c5066285591b4.1626619393.git.lukasstraub2@web.de>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
2021-07-20 16:11:53 +02:00
..
2019-10-10 10:56:17 +02:00
2021-04-30 12:27:48 +02:00
2020-05-18 19:05:25 +02:00
2020-05-18 19:05:25 +02:00
2021-06-29 16:51:21 +02:00
2021-02-15 15:10:14 +01:00
2021-03-19 10:15:06 +01:00
2020-11-09 15:44:21 +01:00
2021-01-08 15:13:38 +00:00
2021-07-12 11:24:00 -05:00
2021-03-11 13:57:08 +00:00
2020-09-15 11:05:13 +02:00
2020-07-06 10:34:14 +02:00
2021-07-09 12:26:05 +02:00