 52b10c9c0c
			
		
	
	
		52b10c9c0c
		
	
	
	
	
		
			
			Right now "qemu-img map" reports compressed blocks as containing data but having no host offset. This is not very informative. Instead, let's add another boolean field named "compressed" in case JSON output mode is specified. This is achieved by utilizing new allocation status flag BDRV_BLOCK_COMPRESSED for bdrv_block_status(). Also update the expected qemu-iotests outputs to contain the new field. Signed-off-by: Andrey Drobyshev <andrey.drobyshev@virtuozzo.com> Message-ID: <20230907210226.953821-3-andrey.drobyshev@virtuozzo.com> Reviewed-by: Kevin Wolf <kwolf@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
		
			
				
	
	
		
			260 lines
		
	
	
		
			14 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
			
		
		
	
	
			260 lines
		
	
	
		
			14 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
| QA output created by 122
 | |
| Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=67108864
 | |
| wrote 67108864/67108864 bytes at offset 0
 | |
| 64 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| 
 | |
| === Check allocation status regression with -B ===
 | |
| 
 | |
| Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864 backing_file=TEST_DIR/t.IMGFMT.base backing_fmt=IMGFMT
 | |
| wrote 3145728/3145728 bytes at offset 0
 | |
| 3 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| Offset          Length          File
 | |
| 0               0x300000        TEST_DIR/t.IMGFMT.orig
 | |
| 0x300000        0x3d00000       TEST_DIR/t.IMGFMT.base
 | |
| 
 | |
| === Check that zero clusters are kept in overlay ===
 | |
| 
 | |
| Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864 backing_file=TEST_DIR/t.IMGFMT.base backing_fmt=IMGFMT
 | |
| wrote 3145728/3145728 bytes at offset 0
 | |
| 3 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 3145728/3145728 bytes at offset 0
 | |
| 3 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 3145728/3145728 bytes at offset 0
 | |
| 3 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 3145728/3145728 bytes at offset 0
 | |
| 3 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 3145728/3145728 bytes at offset 0
 | |
| 3 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 3145728/3145728 bytes at offset 0
 | |
| 3 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| 
 | |
| === Converting to an overlay larger than its backing file ===
 | |
| 
 | |
| Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=268435456
 | |
| Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=805306368 backing_file=TEST_DIR/t.IMGFMT.base backing_fmt=IMGFMT
 | |
| Offset          Length          File
 | |
| 
 | |
| wrote 1048576/1048576 bytes at offset 267386880
 | |
| 1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 1048576/1048576 bytes at offset 629145600
 | |
| 1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| Offset          Length          File
 | |
| 0xff00000       0x100000        TEST_DIR/t.IMGFMT.base
 | |
| 0x25800000      0x100000        TEST_DIR/t.IMGFMT.orig
 | |
| read 1048576/1048576 bytes at offset 267386880
 | |
| 1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 1048576/1048576 bytes at offset 629145600
 | |
| 1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| 
 | |
| === Concatenate multiple source images ===
 | |
| 
 | |
| Formatting 'TEST_DIR/t.IMGFMT.1', fmt=IMGFMT size=4194304
 | |
| Formatting 'TEST_DIR/t.IMGFMT.2', fmt=IMGFMT size=4194304
 | |
| Formatting 'TEST_DIR/t.IMGFMT.3', fmt=IMGFMT size=4194304
 | |
| wrote 65536/65536 bytes at offset 0
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 65536/65536 bytes at offset 0
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 65536/65536 bytes at offset 0
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| Offset          Length          File
 | |
| 0               0x10000         TEST_DIR/t.IMGFMT
 | |
| 0x400000        0x10000         TEST_DIR/t.IMGFMT
 | |
| 0x800000        0x10000         TEST_DIR/t.IMGFMT
 | |
| read 65536/65536 bytes at offset 0
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 65536/65536 bytes at offset 4194304
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 65536/65536 bytes at offset 8388608
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| [{ "start": 0, "length": 65536, "depth": 0, "present": true, "zero": false, "data": true, "compressed": true},
 | |
| { "start": 65536, "length": 4128768, "depth": 0, "present": false, "zero": true, "data": false, "compressed": false},
 | |
| { "start": 4194304, "length": 65536, "depth": 0, "present": true, "zero": false, "data": true, "compressed": true},
 | |
| { "start": 4259840, "length": 4128768, "depth": 0, "present": false, "zero": true, "data": false, "compressed": false},
 | |
| { "start": 8388608, "length": 65536, "depth": 0, "present": true, "zero": false, "data": true, "compressed": true},
 | |
| { "start": 8454144, "length": 4128768, "depth": 0, "present": false, "zero": true, "data": false, "compressed": false}]
 | |
| read 65536/65536 bytes at offset 0
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 65536/65536 bytes at offset 4194304
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 65536/65536 bytes at offset 8388608
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| qemu-img: Having a backing file for the target makes no sense when concatenating multiple input images
 | |
| qemu-img: Having a backing file for the target makes no sense when concatenating multiple input images
 | |
| 
 | |
| === Compression with misaligned allocations and image sizes ===
 | |
| 
 | |
| Formatting 'TEST_DIR/t.IMGFMT.1', fmt=IMGFMT size=1047552
 | |
| Formatting 'TEST_DIR/t.IMGFMT.2', fmt=IMGFMT size=1047552
 | |
| wrote 16384/16384 bytes at offset 16384
 | |
| 16 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 133120/133120 bytes at offset 133120
 | |
| 130 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 1024/1024 bytes at offset 1046528
 | |
| 1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 1024/1024 bytes at offset 0
 | |
| 1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| [{ "start": 0, "length": 65536, "depth": 0, "present": true, "zero": false, "data": true, "compressed": true},
 | |
| { "start": 65536, "length": 65536, "depth": 0, "present": false, "zero": true, "data": false, "compressed": false},
 | |
| { "start": 131072, "length": 196608, "depth": 0, "present": true, "zero": false, "data": true, "compressed": true},
 | |
| { "start": 327680, "length": 655360, "depth": 0, "present": false, "zero": true, "data": false, "compressed": false},
 | |
| { "start": 983040, "length": 65536, "depth": 0, "present": true, "zero": false, "data": true, "compressed": true},
 | |
| { "start": 1048576, "length": 1046528, "depth": 0, "present": false, "zero": true, "data": false, "compressed": false}]
 | |
| read 16384/16384 bytes at offset 0
 | |
| 16 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 16384/16384 bytes at offset 16384
 | |
| 16 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 100352/100352 bytes at offset 32768
 | |
| 98 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 133120/133120 bytes at offset 133120
 | |
| 130 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 780288/780288 bytes at offset 266240
 | |
| 762 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 1024/1024 bytes at offset 1046528
 | |
| 1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 1024/1024 bytes at offset 1047552
 | |
| 1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 1046528/1046528 bytes at offset 1048576
 | |
| 1022 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| 
 | |
| === Full allocation with -S 0 ===
 | |
| 
 | |
| Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
 | |
| wrote 3145728/3145728 bytes at offset 0
 | |
| 3 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 3145728/3145728 bytes at offset 3145728
 | |
| 3 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| 
 | |
| convert -S 0:
 | |
| read 3145728/3145728 bytes at offset 0
 | |
| 3 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 63963136/63963136 bytes at offset 3145728
 | |
| 61 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| [{ "start": 0, "length": 67108864, "depth": 0, "present": true, "zero": false, "data": true, "compressed": false, "offset": OFFSET}]
 | |
| 
 | |
| convert -c -S 0:
 | |
| read 3145728/3145728 bytes at offset 0
 | |
| 3 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 63963136/63963136 bytes at offset 3145728
 | |
| 61 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| [{ "start": 0, "length": 67108864, "depth": 0, "present": true, "zero": false, "data": true, "compressed": true}]
 | |
| Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=67108864
 | |
| wrote 33554432/33554432 bytes at offset 0
 | |
| 32 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864 backing_file=TEST_DIR/t.IMGFMT.base backing_fmt=IMGFMT
 | |
| wrote 3145728/3145728 bytes at offset 0
 | |
| 3 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| 
 | |
| convert -S 0 with source backing file:
 | |
| read 3145728/3145728 bytes at offset 0
 | |
| 3 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 30408704/30408704 bytes at offset 3145728
 | |
| 29 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 33554432/33554432 bytes at offset 33554432
 | |
| 32 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| [{ "start": 0, "length": 67108864, "depth": 0, "present": true, "zero": false, "data": true, "compressed": false, "offset": OFFSET}]
 | |
| 
 | |
| convert -c -S 0 with source backing file:
 | |
| read 3145728/3145728 bytes at offset 0
 | |
| 3 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 30408704/30408704 bytes at offset 3145728
 | |
| 29 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 33554432/33554432 bytes at offset 33554432
 | |
| 32 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| [{ "start": 0, "length": 67108864, "depth": 0, "present": true, "zero": false, "data": true, "compressed": true}]
 | |
| 
 | |
| convert -S 0 -B ...
 | |
| read 3145728/3145728 bytes at offset 0
 | |
| 3 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 30408704/30408704 bytes at offset 3145728
 | |
| 29 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 33554432/33554432 bytes at offset 33554432
 | |
| 32 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| [{ "start": 0, "length": 67108864, "depth": 0, "present": true, "zero": false, "data": true, "compressed": false, "offset": OFFSET}]
 | |
| 
 | |
| convert -c -S 0 -B ...
 | |
| read 3145728/3145728 bytes at offset 0
 | |
| 3 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 30408704/30408704 bytes at offset 3145728
 | |
| 29 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 33554432/33554432 bytes at offset 33554432
 | |
| 32 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| [{ "start": 0, "length": 67108864, "depth": 0, "present": true, "zero": false, "data": true, "compressed": true}]
 | |
| 
 | |
| === Non-zero -S ===
 | |
| 
 | |
| Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
 | |
| wrote 65536/65536 bytes at offset 0
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 1024/1024 bytes at offset 0
 | |
| 1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 1024/1024 bytes at offset 8192
 | |
| 1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 1024/1024 bytes at offset 17408
 | |
| 1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 1024/1024 bytes at offset 66560
 | |
| 1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| 
 | |
| convert -S 4k
 | |
| [{ "start": 0, "length": 4096, "depth": 0, "present": true, "zero": false, "data": true, "compressed": false, "offset": OFFSET},
 | |
| { "start": 4096, "length": 4096, "depth": 0, "present": false, "zero": true, "data": false, "compressed": false},
 | |
| { "start": 8192, "length": 4096, "depth": 0, "present": true, "zero": false, "data": true, "compressed": false, "offset": OFFSET},
 | |
| { "start": 12288, "length": 4096, "depth": 0, "present": false, "zero": true, "data": false, "compressed": false},
 | |
| { "start": 16384, "length": 4096, "depth": 0, "present": true, "zero": false, "data": true, "compressed": false, "offset": OFFSET},
 | |
| { "start": 20480, "length": 67088384, "depth": 0, "present": false, "zero": true, "data": false, "compressed": false}]
 | |
| 
 | |
| convert -c -S 4k
 | |
| [{ "start": 0, "length": 1024, "depth": 0, "present": true, "zero": false, "data": true, "compressed": true},
 | |
| { "start": 1024, "length": 7168, "depth": 0, "present": false, "zero": true, "data": false, "compressed": false},
 | |
| { "start": 8192, "length": 1024, "depth": 0, "present": true, "zero": false, "data": true, "compressed": true},
 | |
| { "start": 9216, "length": 8192, "depth": 0, "present": false, "zero": true, "data": false, "compressed": false},
 | |
| { "start": 17408, "length": 1024, "depth": 0, "present": true, "zero": false, "data": true, "compressed": true},
 | |
| { "start": 18432, "length": 67090432, "depth": 0, "present": false, "zero": true, "data": false, "compressed": false}]
 | |
| 
 | |
| convert -S 8k
 | |
| [{ "start": 0, "length": 24576, "depth": 0, "present": true, "zero": false, "data": true, "compressed": false, "offset": OFFSET},
 | |
| { "start": 24576, "length": 67084288, "depth": 0, "present": false, "zero": true, "data": false, "compressed": false}]
 | |
| 
 | |
| convert -c -S 8k
 | |
| [{ "start": 0, "length": 1024, "depth": 0, "present": true, "zero": false, "data": true, "compressed": true},
 | |
| { "start": 1024, "length": 7168, "depth": 0, "present": false, "zero": true, "data": false, "compressed": false},
 | |
| { "start": 8192, "length": 1024, "depth": 0, "present": true, "zero": false, "data": true, "compressed": true},
 | |
| { "start": 9216, "length": 8192, "depth": 0, "present": false, "zero": true, "data": false, "compressed": false},
 | |
| { "start": 17408, "length": 1024, "depth": 0, "present": true, "zero": false, "data": true, "compressed": true},
 | |
| { "start": 18432, "length": 67090432, "depth": 0, "present": false, "zero": true, "data": false, "compressed": false}]
 | |
| 
 | |
| === -n to a non-zero image ===
 | |
| 
 | |
| Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
 | |
| Formatting 'TEST_DIR/t.IMGFMT.orig', fmt=IMGFMT size=67108864
 | |
| wrote 65536/65536 bytes at offset 0
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| Images are identical.
 | |
| 
 | |
| === -n to an empty image ===
 | |
| 
 | |
| Formatting 'TEST_DIR/t.IMGFMT.orig', fmt=IMGFMT size=67108864
 | |
| Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
 | |
| [{ "start": 0, "length": 67108864, "depth": 0, "present": true, "zero": true, "data": false, "compressed": false}]
 | |
| Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
 | |
| [{ "start": 0, "length": 67108864, "depth": 0, "present": false, "zero": true, "data": false, "compressed": false}]
 | |
| 
 | |
| === -n to an empty image with a backing file ===
 | |
| 
 | |
| Formatting 'TEST_DIR/t.IMGFMT.orig', fmt=IMGFMT size=67108864
 | |
| Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=67108864
 | |
| Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864 backing_file=TEST_DIR/t.IMGFMT.base backing_fmt=IMGFMT
 | |
| [{ "start": 0, "length": 67108864, "depth": 0, "present": true, "zero": true, "data": false, "compressed": false}]
 | |
| Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864 backing_file=TEST_DIR/t.IMGFMT.base backing_fmt=IMGFMT
 | |
| [{ "start": 0, "length": 67108864, "depth": 0, "present": true, "zero": false, "data": true, "compressed": false, "offset": 327680}]
 | |
| 
 | |
| === -n -B to an image without a backing file ===
 | |
| 
 | |
| Formatting 'TEST_DIR/t.IMGFMT.base', fmt=IMGFMT size=67108864
 | |
| Formatting 'TEST_DIR/t.IMGFMT.orig', fmt=IMGFMT size=67108864
 | |
| 
 | |
| === -n incompatible with -o ===
 | |
| 
 | |
| qemu-img: -o has no effect when skipping image creation
 | |
| *** done
 |