 0e72078128
			
		
	
	
		0e72078128
		
	
	
	
	
		
			
			With bash 5.1, the output of the following script changes:
  a=("double  space")
  a=${a[@]:0:1}
  echo "$a"
from "double space" to "double  space", i.e. all white space is
preserved as-is.  This is probably what we actually want here (judging
from the "...to accommodate pathnames with spaces" comment), but before
5.1, we would have to quote the ${} slice to get the same behavior.
In any case, without quoting, the reference output of many iotests is
different between bash 5.1 and pre-5.1, which is not very good.  The
output of 5.1 is what we want, so whatever we do to get pre-5.1 to the
same result, it means we have to fix the reference output of basically
all tests that invoke _send_qemu_cmd (except the ones that only use
single spaces in the commands they invoke).
Instead of quoting the ${} slice (cmd="${$@: 1:...}"), we can also just
not use array slicing and replace the whole thing with a simple "cmd=$1;
shift", which works because all callers quote the whole $cmd argument
anyway.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20201217153803.101231-3-mreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
		
	
			
		
			
				
	
	
		
			82 lines
		
	
	
		
			3.9 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
			
		
		
	
	
			82 lines
		
	
	
		
			3.9 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
| QA output created by 312
 | |
| 
 | |
| ### Create all images
 | |
| 
 | |
| Formatting 'TEST_DIR/t.IMGFMT.0', fmt=IMGFMT size=10485760
 | |
| Formatting 'TEST_DIR/t.IMGFMT.1', fmt=IMGFMT size=10485760
 | |
| Formatting 'TEST_DIR/t.IMGFMT.2', fmt=IMGFMT size=10485760
 | |
| Formatting 'TEST_DIR/t.IMGFMT.3', fmt=IMGFMT size=10485760
 | |
| 
 | |
| ### Output of qemu-img map (empty quorum)
 | |
| 
 | |
| Offset          Length          File
 | |
| 
 | |
| ### Write data to the quorum
 | |
| 
 | |
| wrote 65536/65536 bytes at offset 65536
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 196608/196608 bytes at offset 65536
 | |
| 192 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 131072/131072 bytes at offset 65536
 | |
| 128 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 262144/262144 bytes at offset 1048576
 | |
| 256 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 65536/65536 bytes at offset 1114112
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 196608/196608 bytes at offset 1114112
 | |
| 192 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 131072/131072 bytes at offset 1114112
 | |
| 128 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 65536/65536 bytes at offset 1376256
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 196608/196608 bytes at offset 1376256
 | |
| 192 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 131072/131072 bytes at offset 1376256
 | |
| 128 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 65536/65536 bytes at offset 2097152
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 196608/196608 bytes at offset 2097152
 | |
| 192 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 131072/131072 bytes at offset 2097152
 | |
| 128 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 65536/65536 bytes at offset 2424832
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 65536/65536 bytes at offset 2424832
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| wrote 65536/65536 bytes at offset 2424832
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| read 65536/65536 bytes at offset 2424832
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| 
 | |
| ### Launch the drive-mirror job
 | |
| 
 | |
| { 'execute': 'qmp_capabilities' }
 | |
| {"return": {}}
 | |
| {'execute': 'drive-mirror',
 | |
|                  'arguments': {'device': 'virtio0',
 | |
|                                'format': 'IMGFMT',
 | |
|                                'target': 'TEST_DIR/t.IMGFMT.3',
 | |
|                                'sync':   'full',
 | |
|                                'mode':   'existing' }}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "created", "id": "virtio0"}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "running", "id": "virtio0"}}
 | |
| {"return": {}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "ready", "id": "virtio0"}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "BLOCK_JOB_READY", "data": {"device": "virtio0", "len": 10485760, "offset": 10485760, "speed": 0, "type": "mirror"}}
 | |
| { 'execute': 'block-job-complete',
 | |
|        'arguments': { 'device': 'virtio0' } }
 | |
| {"return": {}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "waiting", "id": "virtio0"}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "JOB_STATUS_CHANGE", "data": {"status": "pending", "id": "virtio0"}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "BLOCK_JOB_COMPLETED", "data": {"device": "virtio0", "len": 10485760, "offset": 10485760, "speed": 0, "type": "mirror"}}
 | |
| { 'execute': 'quit' }
 | |
| 
 | |
| ### Output of qemu-img map (destination image)
 | |
| 
 | |
| Offset          Length          File
 | |
| 0x10000         0x30000         TEST_DIR/t.IMGFMT.3
 | |
| 0x100000        0x10000         TEST_DIR/t.IMGFMT.3
 | |
| 0x120000        0x20000         TEST_DIR/t.IMGFMT.3
 | |
| 0x200000        0x20000         TEST_DIR/t.IMGFMT.3
 | |
| *** done
 |