 89d26d34ce
			
		
	
	
		89d26d34ce
		
	
	
	
	
		
			
			GCC is reporting a NULL pointer dereference when compiling aio_wait_kick() with LTO. The issue is that test-nested-aio-poll.c does not call qemu_init_main_loop(). It doesn't _need_ to because it never calls AIO_WAIT_WHILE(), but it seems that LTO does not do enough dead-code elimination to catch that. Fortunately aio_wait_kick() is only used in few places, and only in block layer or system emulation code; and this test only needs the core event loop functionality. It does not even need iothreads. So remove everything that calls aio_wait_kick(), which is nice for coverage compared to adding the call to qemu_init_main_loop(). Reported-by: Richard W.M. Jones <rjones@redhat.com> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2434 Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
		
			
				
	
	
		
			203 lines
		
	
	
		
			5.9 KiB
		
	
	
	
		
			Meson
		
	
	
	
	
	
			
		
		
	
	
			203 lines
		
	
	
		
			5.9 KiB
		
	
	
	
		
			Meson
		
	
	
	
	
	
| 
 | |
| testblock = declare_dependency(dependencies: [block], sources: 'iothread.c')
 | |
| 
 | |
| tests = {
 | |
|   'check-block-qdict': [],
 | |
|   'check-qdict': [],
 | |
|   'check-qnum': [],
 | |
|   'check-qstring': [],
 | |
|   'check-qlist': [],
 | |
|   'check-qnull': [],
 | |
|   'check-qobject': [],
 | |
|   'check-qjson': [],
 | |
|   'check-qlit': [],
 | |
|   'test-error-report': [],
 | |
|   'test-qobject-output-visitor': [testqapi],
 | |
|   'test-clone-visitor': [testqapi],
 | |
|   'test-qobject-input-visitor': [testqapi],
 | |
|   'test-forward-visitor': [testqapi],
 | |
|   'test-string-input-visitor': [testqapi],
 | |
|   'test-string-output-visitor': [testqapi],
 | |
|   'test-visitor-serialization': [testqapi],
 | |
|   'test-bitmap': [],
 | |
|   'test-resv-mem': [],
 | |
|   # all code tested by test-x86-topo is inside topology.h
 | |
|   'test-x86-topo': [],
 | |
|   'test-cutils': [],
 | |
|   'test-div128': [],
 | |
|   'test-shift128': [],
 | |
|   'test-mul64': [],
 | |
|   # all code tested by test-int128 is inside int128.h
 | |
|   'test-int128': [],
 | |
|   'rcutorture': [],
 | |
|   'test-rcu-list': [],
 | |
|   'test-rcu-simpleq': [],
 | |
|   'test-rcu-tailq': [],
 | |
|   'test-rcu-slist': [],
 | |
|   'test-qdist': [],
 | |
|   'test-qht': [],
 | |
|   'test-qtree': [],
 | |
|   'test-bitops': [],
 | |
|   'test-bitcnt': [],
 | |
|   'test-qgraph': ['../qtest/libqos/qgraph.c'],
 | |
|   'check-qom-interface': [qom],
 | |
|   'check-qom-proplist': [qom],
 | |
|   'test-qemu-opts': [],
 | |
|   'test-keyval': [testqapi],
 | |
|   'test-logging': [],
 | |
|   'test-qapi-util': [],
 | |
|   'test-interval-tree': [],
 | |
|   'test-fifo': [],
 | |
| }
 | |
| 
 | |
| if have_system or have_tools
 | |
|   tests += {
 | |
|     'test-qmp-event': [testqapi],
 | |
|   }
 | |
| 
 | |
|   if seccomp.found()
 | |
|     tests += {'test-seccomp': ['../../system/qemu-seccomp.c', seccomp]}
 | |
|   endif
 | |
| endif
 | |
| 
 | |
| if have_block
 | |
|   tests += {
 | |
|     'test-coroutine': [testblock],
 | |
|     'test-aio': [testblock],
 | |
|     'test-aio-multithread': [testblock],
 | |
|     'test-throttle': [testblock],
 | |
|     'test-thread-pool': [testblock],
 | |
|     'test-hbitmap': [testblock],
 | |
|     'test-bdrv-drain': [testblock],
 | |
|     'test-bdrv-graph-mod': [testblock],
 | |
|     'test-blockjob': [testblock],
 | |
|     'test-blockjob-txn': [testblock],
 | |
|     'test-block-backend': [testblock],
 | |
|     'test-block-iothread': [testblock],
 | |
|     'test-write-threshold': [testblock],
 | |
|     'test-crypto-hash': [crypto],
 | |
|     'test-crypto-hmac': [crypto],
 | |
|     'test-crypto-cipher': [crypto],
 | |
|     'test-crypto-akcipher': [crypto],
 | |
|     'test-crypto-secret': [crypto, keyutils],
 | |
|     'test-crypto-der': [crypto],
 | |
|     'test-authz-simple': [authz],
 | |
|     'test-authz-list': [authz],
 | |
|     'test-authz-listfile': [authz],
 | |
|     'test-io-task': [testblock],
 | |
|     'test-io-channel-socket': ['socket-helpers.c', 'io-channel-helpers.c', io],
 | |
|     'test-io-channel-file': ['io-channel-helpers.c', io],
 | |
|     'test-io-channel-command': ['io-channel-helpers.c', io],
 | |
|     'test-io-channel-buffer': ['io-channel-helpers.c', io],
 | |
|     'test-io-channel-null': [io],
 | |
|     'test-crypto-ivgen': [io],
 | |
|     'test-crypto-afsplit': [io],
 | |
|     'test-crypto-block': [io],
 | |
|     'test-timed-average': [],
 | |
|     'test-uuid': [],
 | |
|   }
 | |
|   if gnutls.found() and \
 | |
|      tasn1.found() and \
 | |
|      host_os != 'windows'
 | |
|     tests += {
 | |
|       'test-crypto-tlscredsx509': ['crypto-tls-x509-helpers.c',
 | |
|                                    tasn1, crypto, gnutls],
 | |
|       'test-crypto-tlssession': ['crypto-tls-x509-helpers.c', 'crypto-tls-psk-helpers.c',
 | |
|                                  tasn1, crypto, gnutls],
 | |
|       'test-io-channel-tls': ['io-channel-helpers.c', 'crypto-tls-x509-helpers.c',
 | |
|                               tasn1, io, crypto, gnutls]}
 | |
|   endif
 | |
|   if pam.found()
 | |
|     tests += {'test-authz-pam': [authz]}
 | |
|   endif
 | |
|   if xts == 'private'
 | |
|     tests += {'test-crypto-xts': [crypto, io]}
 | |
|   endif
 | |
|   if host_os != 'windows'
 | |
|     tests += {
 | |
|       'test-image-locking': [testblock],
 | |
|       'test-nested-aio-poll': [],
 | |
|     }
 | |
|   endif
 | |
|   if config_host_data.get('CONFIG_REPLICATION')
 | |
|     tests += {'test-replication': [testblock]}
 | |
|   endif
 | |
|   tests += {'test-crypto-pbkdf': [io]}
 | |
| endif
 | |
| 
 | |
| if have_system
 | |
|   tests += {
 | |
|     'ptimer-test': ['ptimer-test-stubs.c', meson.project_source_root() / 'hw/core/ptimer.c'],
 | |
|     'test-iov': [],
 | |
|     'test-opts-visitor': [testqapi],
 | |
|     'test-xs-node': [qom],
 | |
|     'test-virtio-dmabuf': [meson.project_source_root() / 'hw/display/virtio-dmabuf.c'],
 | |
|     'test-qmp-cmds': [testqapi],
 | |
|     'test-xbzrle': [migration],
 | |
|     'test-util-sockets': ['socket-helpers.c'],
 | |
|     'test-base64': [],
 | |
|     'test-bufferiszero': [],
 | |
|     'test-smp-parse': [qom, meson.project_source_root() / 'hw/core/machine-smp.c'],
 | |
|     'test-vmstate': [migration, io],
 | |
|     'test-yank': ['socket-helpers.c', qom, io, chardev]
 | |
|   }
 | |
|   if config_host_data.get('CONFIG_INOTIFY1')
 | |
|     tests += {'test-util-filemonitor': []}
 | |
|   endif
 | |
| 
 | |
|   # Some tests: test-char, test-qdev-global-props, and test-qga,
 | |
|   # are not runnable under TSan due to a known issue.
 | |
|   # https://github.com/google/sanitizers/issues/1116
 | |
|   if not get_option('tsan')
 | |
|     if host_os != 'windows'
 | |
|         tests += {
 | |
|           'test-char': ['socket-helpers.c', qom, io, chardev]
 | |
|         }
 | |
|     endif
 | |
| 
 | |
|     tests += {
 | |
|       'test-qdev-global-props': [qom, hwcore]
 | |
|     }
 | |
|   endif
 | |
| endif
 | |
| 
 | |
| if have_ga and host_os == 'linux'
 | |
|   tests += {'test-qga': ['../qtest/libqmp.c']}
 | |
|   test_deps += {'test-qga': qga}
 | |
| endif
 | |
| 
 | |
| test_env = environment()
 | |
| test_env.set('G_TEST_SRCDIR', meson.current_source_dir())
 | |
| test_env.set('G_TEST_BUILDDIR', meson.current_build_dir())
 | |
| 
 | |
| slow_tests = {
 | |
|   'test-aio-multithread' : 120,
 | |
|   'test-bufferiszero': 60,
 | |
|   'test-crypto-block' : 300,
 | |
|   'test-crypto-tlscredsx509': 90,
 | |
|   'test-crypto-tlssession': 90,
 | |
|   'test-replication': 60,
 | |
| }
 | |
| 
 | |
| foreach test_name, extra: tests
 | |
|   src = [test_name + '.c']
 | |
|   deps = [qemuutil]
 | |
|   if extra.length() > 0
 | |
|     # use a sourceset to quickly separate sources and deps
 | |
|     test_ss = ss.source_set()
 | |
|     test_ss.add(extra)
 | |
|     src += test_ss.all_sources()
 | |
|     deps += test_ss.all_dependencies()
 | |
|   endif
 | |
|   exe = executable(test_name, src, genh, dependencies: deps)
 | |
| 
 | |
|   test(test_name, exe,
 | |
|        depends: test_deps.get(test_name, []),
 | |
|        env: test_env,
 | |
|        args: ['--tap', '-k'],
 | |
|        protocol: 'tap',
 | |
|        timeout: slow_tests.get(test_name, 30),
 | |
|        priority: slow_tests.get(test_name, 30),
 | |
|        suite: ['unit'])
 | |
| endforeach
 |