 0e72078128
			
		
	
	
		0e72078128
		
	
	
	
	
		
			
			With bash 5.1, the output of the following script changes:
  a=("double  space")
  a=${a[@]:0:1}
  echo "$a"
from "double space" to "double  space", i.e. all white space is
preserved as-is.  This is probably what we actually want here (judging
from the "...to accommodate pathnames with spaces" comment), but before
5.1, we would have to quote the ${} slice to get the same behavior.
In any case, without quoting, the reference output of many iotests is
different between bash 5.1 and pre-5.1, which is not very good.  The
output of 5.1 is what we want, so whatever we do to get pre-5.1 to the
same result, it means we have to fix the reference output of basically
all tests that invoke _send_qemu_cmd (except the ones that only use
single spaces in the commands they invoke).
Instead of quoting the ${} slice (cmd="${$@: 1:...}"), we can also just
not use array slicing and replace the whole thing with a simple "cmd=$1;
shift", which works because all callers quote the whole $cmd argument
anyway.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Message-Id: <20201217153803.101231-3-mreitz@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
		
	
			
		
			
				
	
	
		
			67 lines
		
	
	
		
			2.3 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
			
		
		
	
	
			67 lines
		
	
	
		
			2.3 KiB
		
	
	
	
		
			Plaintext
		
	
	
	
	
	
| QA output created by 183
 | |
| Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
 | |
| Formatting 'TEST_DIR/t.IMGFMT.dest', fmt=IMGFMT size=67108864
 | |
| 
 | |
| === Starting VMs ===
 | |
| 
 | |
| { 'execute': 'qmp_capabilities' }
 | |
| {"return": {}}
 | |
| { 'execute': 'qmp_capabilities' }
 | |
| {"return": {}}
 | |
| 
 | |
| === Write something on the source ===
 | |
| 
 | |
| { 'execute': 'human-monitor-command',
 | |
|        'arguments': { 'command-line':
 | |
|                       'qemu-io disk "write -P 0x55 0 64k"' } }
 | |
| wrote 65536/65536 bytes at offset 0
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| {"return": ""}
 | |
| { 'execute': 'human-monitor-command',
 | |
|        'arguments': { 'command-line':
 | |
|                       'qemu-io disk "read -P 0x55 0 64k"' } }
 | |
| read 65536/65536 bytes at offset 0
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| {"return": ""}
 | |
| 
 | |
| === Do block migration to destination ===
 | |
| 
 | |
| { 'execute': 'migrate',
 | |
|        'arguments': { 'uri': 'unix:SOCK_DIR/migrate', 'blk': true } }
 | |
| {"return": {}}
 | |
| { 'execute': 'query-status' }
 | |
| {"return": {"status": "postmigrate", "singlestep": false, "running": false}}
 | |
| 
 | |
| === Do some I/O on the destination ===
 | |
| 
 | |
| { 'execute': 'query-status' }
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "RESUME"}
 | |
| {"return": {"status": "running", "singlestep": false, "running": true}}
 | |
| { 'execute': 'human-monitor-command',
 | |
|        'arguments': { 'command-line':
 | |
|                       'qemu-io disk "read -P 0x55 0 64k"' } }
 | |
| read 65536/65536 bytes at offset 0
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| {"return": ""}
 | |
| { 'execute': 'human-monitor-command',
 | |
|        'arguments': { 'command-line':
 | |
|                       'qemu-io disk "write -P 0x66 1M 64k"' } }
 | |
| wrote 65536/65536 bytes at offset 1048576
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| {"return": ""}
 | |
| 
 | |
| === Shut down and check image ===
 | |
| 
 | |
| {"execute":"quit"}
 | |
| {"return": {}}
 | |
| {"execute":"quit"}
 | |
| {"return": {}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "SHUTDOWN", "data": {"guest": false, "reason": "host-qmp-quit"}}
 | |
| {"timestamp": {"seconds":  TIMESTAMP, "microseconds":  TIMESTAMP}, "event": "SHUTDOWN", "data": {"guest": false, "reason": "host-qmp-quit"}}
 | |
| No errors were found on the image.
 | |
| No errors were found on the image.
 | |
| wrote 65536/65536 bytes at offset 1048576
 | |
| 64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
 | |
| Images are identical.
 | |
| *** done
 |