hostmem-file and hostmem-memfd use the whole object path for the
memory region name, and hostname-ram uses only the path component (the
object id, or canonical path basename):
qemu -m 1024 -object memory-backend-file,id=mem,size=1G,mem-path=/tmp/foo -numa node,memdev=mem -monitor stdio
(qemu) info ramblock
              Block Name    PSize              Offset               Used              Total
            /objects/mem    4 KiB  0x0000000000000000 0x0000000040000000 0x0000000040000000
qemu -m 1024 -object memory-backend-memfd,id=mem,size=1G -numa node,memdev=mem -monitor stdio
(qemu) info ramblock
              Block Name    PSize              Offset               Used              Total
            /objects/mem    4 KiB  0x0000000000000000 0x0000000040000000 0x0000000040000000
qemu -m 1024 -object memory-backend-ram,id=mem,size=1G -numa node,memdev=mem -monitor stdio
(qemu) info ramblock
              Block Name    PSize              Offset               Used              Total
                     mem    4 KiB  0x0000000000000000 0x0000000040000000 0x0000000040000000
For consistency, change to use object id for -file and -memfd as well
with >= 4.0.
Having a consistent naming allows to migrate to different hostmem
backends.
Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Acked-by: Eduardo Habkost <ehabkost@redhat.com>
		
	
			
		
			
				
	
	
		
			55 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			55 lines
		
	
	
		
			1.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * QEMU Host Memory Backend
 | 
						|
 *
 | 
						|
 * Copyright (C) 2013-2014 Red Hat Inc
 | 
						|
 *
 | 
						|
 * Authors:
 | 
						|
 *   Igor Mammedov <imammedo@redhat.com>
 | 
						|
 *
 | 
						|
 * This work is licensed under the terms of the GNU GPL, version 2 or later.
 | 
						|
 * See the COPYING file in the top-level directory.
 | 
						|
 */
 | 
						|
#include "qemu/osdep.h"
 | 
						|
#include "sysemu/hostmem.h"
 | 
						|
#include "qapi/error.h"
 | 
						|
#include "qom/object_interfaces.h"
 | 
						|
 | 
						|
#define TYPE_MEMORY_BACKEND_RAM "memory-backend-ram"
 | 
						|
 | 
						|
static void
 | 
						|
ram_backend_memory_alloc(HostMemoryBackend *backend, Error **errp)
 | 
						|
{
 | 
						|
    char *name;
 | 
						|
 | 
						|
    if (!backend->size) {
 | 
						|
        error_setg(errp, "can't create backend with size 0");
 | 
						|
        return;
 | 
						|
    }
 | 
						|
 | 
						|
    name = host_memory_backend_get_name(backend);
 | 
						|
    memory_region_init_ram_shared_nomigrate(&backend->mr, OBJECT(backend), name,
 | 
						|
                           backend->size, backend->share, errp);
 | 
						|
    g_free(name);
 | 
						|
}
 | 
						|
 | 
						|
static void
 | 
						|
ram_backend_class_init(ObjectClass *oc, void *data)
 | 
						|
{
 | 
						|
    HostMemoryBackendClass *bc = MEMORY_BACKEND_CLASS(oc);
 | 
						|
 | 
						|
    bc->alloc = ram_backend_memory_alloc;
 | 
						|
}
 | 
						|
 | 
						|
static const TypeInfo ram_backend_info = {
 | 
						|
    .name = TYPE_MEMORY_BACKEND_RAM,
 | 
						|
    .parent = TYPE_MEMORY_BACKEND,
 | 
						|
    .class_init = ram_backend_class_init,
 | 
						|
};
 | 
						|
 | 
						|
static void register_types(void)
 | 
						|
{
 | 
						|
    type_register_static(&ram_backend_info);
 | 
						|
}
 | 
						|
 | 
						|
type_init(register_types);
 |