246ccfbf44
Commit 1e08fd0a46 ("vhost-vsock: SOCK_SEQPACKET feature bit support")
enabled the SEQPACKET feature bit.
This commit is released with QEMU 6.1, so if we try to migrate a VM where
the host kernel supports SEQPACKET but machine type version is less than
6.1, we get the following errors:
Features 0x130000002 unsupported. Allowed features: 0x179000000
Failed to load virtio-vhost_vsock:virtio
error while loading state for instance 0x0 of device '0000:00:05.0/virtio-vhost_vsock'
load of migration failed: Operation not permitted
Let's disable the feature bit for machine types < 6.1.
We add a new OnOffAuto property for this, called `seqpacket`.
When it is `auto` (default), QEMU behaves as before, trying to enable the
feature, when it is `on` QEMU will fail if the backend (vhost-vsock
kernel module) doesn't support it.
Fixes: 1e08fd0a46 ("vhost-vsock: SOCK_SEQPACKET feature bit support")
Cc: qemu-stable@nongnu.org
Reported-by: Jiang Wang <jiang.wang@bytedance.com>
Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Message-Id: <20210921161642.206461-2-sgarzare@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
(cherry picked from commit d6a9378f47515c6d70dbff4912c5740c98709880)
Signed-off-by: Michael Roth <michael.roth@amd.com>
40 lines
789 B
C
40 lines
789 B
C
/*
|
|
* Vhost vsock virtio device
|
|
*
|
|
* Copyright 2015 Red Hat, Inc.
|
|
*
|
|
* Authors:
|
|
* Stefan Hajnoczi <stefanha@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or
|
|
* (at your option) any later version. See the COPYING file in the
|
|
* top-level directory.
|
|
*/
|
|
|
|
#ifndef QEMU_VHOST_VSOCK_H
|
|
#define QEMU_VHOST_VSOCK_H
|
|
|
|
#include "hw/virtio/vhost-vsock-common.h"
|
|
#include "qom/object.h"
|
|
|
|
#define TYPE_VHOST_VSOCK "vhost-vsock-device"
|
|
OBJECT_DECLARE_SIMPLE_TYPE(VHostVSock, VHOST_VSOCK)
|
|
|
|
typedef struct {
|
|
uint64_t guest_cid;
|
|
char *vhostfd;
|
|
} VHostVSockConf;
|
|
|
|
struct VHostVSock {
|
|
/*< private >*/
|
|
VHostVSockCommon parent;
|
|
VHostVSockConf conf;
|
|
|
|
/* features */
|
|
OnOffAuto seqpacket;
|
|
|
|
/*< public >*/
|
|
};
|
|
|
|
#endif /* QEMU_VHOST_VSOCK_H */
|