c5eb8d6336
When running the instruction
```
cbo.flush 0(x0)
```
QEMU would segfault.
The issue was in cpu_gpr[a->rs1] as QEMU does not have cpu_gpr[0]
allocated.
In order to fix this let's use the existing get_address()
helper. This also has the benefit of performing pointer mask
calculations on the address specified in rs1.
The pointer masking specificiation specifically states:
"""
Cache Management Operations: All instructions in Zicbom, Zicbop and Zicboz
"""
So this is the correct behaviour and we previously have been incorrectly
not masking the address.
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
Reported-by: Fabian Thomas <fabian.thomas@cispa.de>
Fixes: e05da09b7cfd ("target/riscv: implement Zicbom extension")
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-stable <qemu-stable@nongnu.org>
Message-ID: <20240514023910.301766-1-alistair.francis@wdc.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
66 lines
1.8 KiB
C++
66 lines
1.8 KiB
C++
/*
|
|
* RISC-V translation routines for the RISC-V CBO Extension.
|
|
*
|
|
* Copyright (c) 2021 Philipp Tomsich, philipp.tomsich@vrull.eu
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify it
|
|
* under the terms and conditions of the GNU General Public License,
|
|
* version 2 or later, as published by the Free Software Foundation.
|
|
*
|
|
* This program is distributed in the hope it will be useful, but WITHOUT
|
|
* ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
|
|
* FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for
|
|
* more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along with
|
|
* this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#define REQUIRE_ZICBOM(ctx) do { \
|
|
if (!ctx->cfg_ptr->ext_zicbom) { \
|
|
return false; \
|
|
} \
|
|
} while (0)
|
|
|
|
#define REQUIRE_ZICBOZ(ctx) do { \
|
|
if (!ctx->cfg_ptr->ext_zicboz) { \
|
|
return false; \
|
|
} \
|
|
} while (0)
|
|
|
|
static bool trans_cbo_clean(DisasContext *ctx, arg_cbo_clean *a)
|
|
{
|
|
REQUIRE_ZICBOM(ctx);
|
|
TCGv src = get_address(ctx, a->rs1, 0);
|
|
|
|
gen_helper_cbo_clean_flush(tcg_env, src);
|
|
return true;
|
|
}
|
|
|
|
static bool trans_cbo_flush(DisasContext *ctx, arg_cbo_flush *a)
|
|
{
|
|
REQUIRE_ZICBOM(ctx);
|
|
TCGv src = get_address(ctx, a->rs1, 0);
|
|
|
|
gen_helper_cbo_clean_flush(tcg_env, src);
|
|
return true;
|
|
}
|
|
|
|
static bool trans_cbo_inval(DisasContext *ctx, arg_cbo_inval *a)
|
|
{
|
|
REQUIRE_ZICBOM(ctx);
|
|
TCGv src = get_address(ctx, a->rs1, 0);
|
|
|
|
gen_helper_cbo_inval(tcg_env, src);
|
|
return true;
|
|
}
|
|
|
|
static bool trans_cbo_zero(DisasContext *ctx, arg_cbo_zero *a)
|
|
{
|
|
REQUIRE_ZICBOZ(ctx);
|
|
TCGv src = get_address(ctx, a->rs1, 0);
|
|
|
|
gen_helper_cbo_zero(tcg_env, src);
|
|
return true;
|
|
}
|