5a8d024f8d
These tests currently fail if VNC support has not been compiled into the QEMU binary. Let's add some checks to skip the tests in that case instead. Message-ID: <20250325064715.278876-1-thuth@redhat.com> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Signed-off-by: Thomas Huth <thuth@redhat.com>
111 lines
4.0 KiB
Python
Executable File
111 lines
4.0 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
#
|
|
# Simple functional tests for VNC functionality
|
|
#
|
|
# Copyright (c) 2018 Red Hat, Inc.
|
|
#
|
|
# Author:
|
|
# Cleber Rosa <crosa@redhat.com>
|
|
#
|
|
# This work is licensed under the terms of the GNU GPL, version 2 or
|
|
# later. See the COPYING file in the top-level directory.
|
|
|
|
import socket
|
|
from typing import List
|
|
from qemu.machine.machine import VMLaunchFailure
|
|
|
|
from qemu_test import QemuSystemTest
|
|
from qemu_test.ports import Ports
|
|
|
|
VNC_ADDR = '127.0.0.1'
|
|
|
|
def check_connect(port: int) -> bool:
|
|
with socket.socket(socket.AF_INET, socket.SOCK_STREAM) as sock:
|
|
try:
|
|
sock.connect((VNC_ADDR, port))
|
|
except ConnectionRefusedError:
|
|
return False
|
|
|
|
return True
|
|
|
|
class Vnc(QemuSystemTest):
|
|
|
|
def test_no_vnc_change_password(self):
|
|
self.vm.add_args('-nodefaults', '-S')
|
|
self.vm.launch()
|
|
|
|
query_vnc_response = self.vm.qmp('query-vnc')
|
|
if 'error' in query_vnc_response:
|
|
self.assertEqual(query_vnc_response['error']['class'],
|
|
'CommandNotFound')
|
|
self.skipTest('VNC support not available')
|
|
self.assertFalse(query_vnc_response['return']['enabled'])
|
|
|
|
set_password_response = self.vm.qmp('change-vnc-password',
|
|
password='new_password')
|
|
self.assertIn('error', set_password_response)
|
|
self.assertEqual(set_password_response['error']['class'],
|
|
'GenericError')
|
|
self.assertEqual(set_password_response['error']['desc'],
|
|
'Could not set password')
|
|
|
|
def launch_guarded(self):
|
|
try:
|
|
self.vm.launch()
|
|
except VMLaunchFailure as excp:
|
|
if "-vnc: invalid option" in excp.output:
|
|
self.skipTest("VNC support not available")
|
|
else:
|
|
self.log.info("unhandled launch failure: %s", excp.output)
|
|
raise excp
|
|
|
|
def test_change_password_requires_a_password(self):
|
|
self.vm.add_args('-nodefaults', '-S', '-vnc', ':1,to=999')
|
|
self.launch_guarded()
|
|
self.assertTrue(self.vm.qmp('query-vnc')['return']['enabled'])
|
|
set_password_response = self.vm.qmp('change-vnc-password',
|
|
password='new_password')
|
|
self.assertIn('error', set_password_response)
|
|
self.assertEqual(set_password_response['error']['class'],
|
|
'GenericError')
|
|
self.assertEqual(set_password_response['error']['desc'],
|
|
'Could not set password')
|
|
|
|
def test_change_password(self):
|
|
self.vm.add_args('-nodefaults', '-S', '-vnc', ':1,to=999,password=on')
|
|
self.launch_guarded()
|
|
self.assertTrue(self.vm.qmp('query-vnc')['return']['enabled'])
|
|
self.vm.cmd('change-vnc-password',
|
|
password='new_password')
|
|
|
|
def do_test_change_listen(self, a, b, c):
|
|
self.assertFalse(check_connect(a))
|
|
self.assertFalse(check_connect(b))
|
|
self.assertFalse(check_connect(c))
|
|
|
|
self.vm.add_args('-nodefaults', '-S', '-vnc', f'{VNC_ADDR}:{a - 5900}')
|
|
self.launch_guarded()
|
|
self.assertEqual(self.vm.qmp('query-vnc')['return']['service'], str(a))
|
|
self.assertTrue(check_connect(a))
|
|
self.assertFalse(check_connect(b))
|
|
self.assertFalse(check_connect(c))
|
|
|
|
self.vm.cmd('display-update', type='vnc',
|
|
addresses=[{'type': 'inet', 'host': VNC_ADDR,
|
|
'port': str(b)},
|
|
{'type': 'inet', 'host': VNC_ADDR,
|
|
'port': str(c)}])
|
|
self.assertEqual(self.vm.qmp('query-vnc')['return']['service'], str(b))
|
|
self.assertFalse(check_connect(a))
|
|
self.assertTrue(check_connect(b))
|
|
self.assertTrue(check_connect(c))
|
|
|
|
def test_change_listen(self):
|
|
with Ports() as ports:
|
|
a, b, c = ports.find_free_ports(3)
|
|
self.do_test_change_listen(a, b, c)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
QemuSystemTest.main()
|