david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hw/wm8750: Fix potential buffer overflow

Browse Source 
Report from smatch:

hw/wm8750.c:369 wm8750_tx(12) error: buffer overflow 's->i2c_data' 2 <= 2

It looks like the preprocessor statements were simply misplaced.

Replace also __FUNCTION__ by __func__ to please checkpatch.pl.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org> 
Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
This commit is contained in:
Stefan Weil 2012-09-03 22:56:00 +02:00 committed by Aurelien Jarno
parent 6845df48ce
commit 149eeb5fe5
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hw/wm8750.c
View File

@ -361,10 +361,10 @@ static int wm8750_tx(I2CSlave *i2c, uint8_t data)
uint16_t value; uint16_t value;
if (s->i2c_len >= 2) { if (s->i2c_len >= 2) {
printf("%s: long message (%i bytes)\n", __FUNCTION__, s->i2c_len);
#ifdef VERBOSE #ifdef VERBOSE
return 1; printf("%s: long message (%i bytes)\n", __func__, s->i2c_len);
#endif #endif
return 1;
} }
s->i2c_data[s->i2c_len ++] = data; s->i2c_data[s->i2c_len ++] = data;
if (s->i2c_len != 2) if (s->i2c_len != 2)