david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qga: unlink just created guest-file if fchmod() or fdopen() fails on it

Browse Source 
We shouldn't allow guest filesystem pollution on error paths.

Suggested-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
This commit is contained in:
Laszlo Ersek 2013-05-08 17:31:36 +02:00 committed by Michael Roth
parent 8fe6bbca71
commit 2b72001806
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
qga/commands-posix.c
View File

@ -355,6 +355,9 @@ safe_open_or_create(const char *path, const char *mode, Error **err)
} }
close(fd); close(fd);
if (oflag & O_CREAT) {
unlink(path);
}
} }
} }