qcow2: fix new_blocks double-free in alloc_refcount_block()
Commit de82815db1c89da058b7fb941dab137d6d9ab738 ("qcow2: Handle failure
for potentially large allocations") introduced a double-free of
new_blocks in the alloc_refcount_block() error path.
The qemu-iotests qcow2 026 test case was failing because qemu-io
segfaulted.
Make sure new_blocks is NULL after we free it the first time.
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
			
			
This commit is contained in:
		
							parent
							
								
									94c83a24c1
								
							
						
					
					
						commit
						39ba3bf69c
					
				@ -381,6 +381,7 @@ static int alloc_refcount_block(BlockDriverState *bs,
 | 
			
		||||
    ret = bdrv_pwrite_sync(bs->file, meta_offset, new_blocks,
 | 
			
		||||
        blocks_clusters * s->cluster_size);
 | 
			
		||||
    g_free(new_blocks);
 | 
			
		||||
    new_blocks = NULL;
 | 
			
		||||
    if (ret < 0) {
 | 
			
		||||
        goto fail_table;
 | 
			
		||||
    }
 | 
			
		||||
 | 
			
		||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user