david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ehci: fix overflow in frame timer code

Browse Source 
In case the frame timer doesn't run for a while due to the host being
busy skipped_uframes can become big enough that UFRAME_TIMER_NS *
skipped_uframes overflows.  Which in turn throws off all subsequent
ehci frame timer calculations.

Reported-by: 李林 <8610_28@163.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Message-id: 20170515104543.32044-1-kraxel@redhat.com
This commit is contained in:
Gerd Hoffmann 2017-05-15 12:45:43 +02:00
parent 9964e96dc9
commit 3ae7eb88c4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/usb/hcd-ehci.c
View File

@ -2238,7 +2238,7 @@ static void ehci_frame_timer(void *opaque)
int need_timer = 0; int need_timer = 0;
int64_t expire_time, t_now; int64_t expire_time, t_now;
uint64_t ns_elapsed; uint64_t ns_elapsed;
int uframes, skipped_uframes; uint64_t uframes, skipped_uframes;
int i; int i;
t_now = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL); t_now = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL);