david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qemu.py: Simplify QMP key-conversion

Browse Source 
The QMP key conversion consist of '_'s to be replaced with '-'s, which
can easily be done by a single `str.replace` method which is faster and
does not require `string` module import.

Signed-off-by: Lukáš Doktor <ldoktor@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20170818142613.32394-5-ldoktor@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
This commit is contained in:
Lukáš Doktor 2017-08-18 16:26:07 +02:00 committed by Eduardo Habkost
parent 7f33ca7878
commit 41f714b190
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
scripts/qemu.py
View File

@ -13,7 +13,6 @@
# #
import errno import errno
import string
import os import os
import sys import sys
import subprocess import subprocess
@ -195,14 +194,12 @@ class QEMUMachine(object):
self._load_io_log() self._load_io_log()
self._post_shutdown() self._post_shutdown()
underscore_to_dash = string.maketrans('_', '-')
def qmp(self, cmd, conv_keys=True, **args): def qmp(self, cmd, conv_keys=True, **args):
'''Invoke a QMP command and return the response dict''' '''Invoke a QMP command and return the response dict'''
qmp_args = dict() qmp_args = dict()
for key, value in args.iteritems(): for key, value in args.iteritems():
if conv_keys: if conv_keys:
qmp_args[key.translate(self.underscore_to_dash)] = value qmp_args[key.replace('_', '-')] = value
else: else:
qmp_args[key] = value qmp_args[key] = value