david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

monitor: fix double-free of request error

Browse Source 
qmp_error_response() will free the given error. Fix double-free in
later qmp_request_free().

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Message-Id: <20180705164201.9853-1-marcandre.lureau@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Fixes: 1cc37471525d03f963bc71d724f0dc9eab888fc1
Signed-off-by: Markus Armbruster <armbru@redhat.com>
This commit is contained in:
Marc-André Lureau 2018-07-05 18:42:01 +02:00 committed by Markus Armbruster
parent c447afd578
commit 42eab8dbec
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
monitor.c
View File

@ -4186,6 +4186,7 @@ static void monitor_qmp_bh_dispatcher(void *data)
} else { } else {
assert(req_obj->err); assert(req_obj->err);
rsp = qmp_error_response(req_obj->err); rsp = qmp_error_response(req_obj->err);
req_obj->err = NULL;
monitor_qmp_respond(req_obj->mon, rsp, NULL); monitor_qmp_respond(req_obj->mon, rsp, NULL);
qobject_unref(rsp); qobject_unref(rsp);
} }