david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

cow: return errno instead of -1

Browse Source 
Remove not needed ret = 0 assignment.

Signed-off-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Juan Quintela 2010-03-04 10:00:30 +01:00 committed by Anthony Liguori
parent e53dbee05d
commit 48b66db9ea
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
block/cow.c
View File

@ -224,7 +224,7 @@ static int cow_create(const char *filename, QEMUOptionParameter *options)
cow_fd = open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY, cow_fd = open(filename, O_WRONLY | O_CREAT | O_TRUNC | O_BINARY,
0644); 0644);
if (cow_fd < 0) if (cow_fd < 0)
return -1; return -errno;
memset(&cow_header, 0, sizeof(cow_header)); memset(&cow_header, 0, sizeof(cow_header));
cow_header.magic = cpu_to_be32(COW_MAGIC); cow_header.magic = cpu_to_be32(COW_MAGIC);
cow_header.version = cpu_to_be32(COW_VERSION); cow_header.version = cpu_to_be32(COW_VERSION);
@ -251,7 +251,7 @@ static int cow_create(const char *filename, QEMUOptionParameter *options)
cow_header.size = cpu_to_be64(image_sectors * 512); cow_header.size = cpu_to_be64(image_sectors * 512);
ret = qemu_write_full(cow_fd, &cow_header, sizeof(cow_header)); ret = qemu_write_full(cow_fd, &cow_header, sizeof(cow_header));
if (ret != sizeof(cow_header)) { if (ret != sizeof(cow_header)) {
ret = -1; ret = -errno;
goto exit; goto exit;
} }
@ -262,7 +262,6 @@ static int cow_create(const char *filename, QEMUOptionParameter *options)
goto exit; goto exit;
} }
ret = 0;
exit: exit:
close(cow_fd); close(cow_fd);
return ret; return ret;