test-qemu-opts: Cover qemu_opts_parse()
The new tests demonstrate a few bugs, all clearly marked. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Message-Id: <1487708048-2131-2-git-send-email-armbru@redhat.com> [A few additional test cases squashed in, see Message-ID: <871supjijq.fsf@dusky.pond.sub.org>]
This commit is contained in:
		
							parent
							
								
									10f25e4844
								
							
						
					
					
						commit
						694baf57ae
					
				@ -8,6 +8,7 @@
 | 
				
			|||||||
 */
 | 
					 */
 | 
				
			||||||
 | 
					
 | 
				
			||||||
#include "qemu/osdep.h"
 | 
					#include "qemu/osdep.h"
 | 
				
			||||||
 | 
					#include "qemu/cutils.h"
 | 
				
			||||||
#include "qapi/error.h"
 | 
					#include "qapi/error.h"
 | 
				
			||||||
#include "qapi/qmp/qstring.h"
 | 
					#include "qapi/qmp/qstring.h"
 | 
				
			||||||
#include "qemu/config-file.h"
 | 
					#include "qemu/config-file.h"
 | 
				
			||||||
@ -29,6 +30,9 @@ static QemuOptsList opts_list_01 = {
 | 
				
			|||||||
        },{
 | 
					        },{
 | 
				
			||||||
            .name = "number1",
 | 
					            .name = "number1",
 | 
				
			||||||
            .type = QEMU_OPT_NUMBER,
 | 
					            .type = QEMU_OPT_NUMBER,
 | 
				
			||||||
 | 
					        },{
 | 
				
			||||||
 | 
					            .name = "number2",
 | 
				
			||||||
 | 
					            .type = QEMU_OPT_NUMBER,
 | 
				
			||||||
        },
 | 
					        },
 | 
				
			||||||
        { /* end of list */ }
 | 
					        { /* end of list */ }
 | 
				
			||||||
    },
 | 
					    },
 | 
				
			||||||
@ -41,15 +45,24 @@ static QemuOptsList opts_list_02 = {
 | 
				
			|||||||
        {
 | 
					        {
 | 
				
			||||||
            .name = "str1",
 | 
					            .name = "str1",
 | 
				
			||||||
            .type = QEMU_OPT_STRING,
 | 
					            .type = QEMU_OPT_STRING,
 | 
				
			||||||
        },{
 | 
					 | 
				
			||||||
            .name = "bool1",
 | 
					 | 
				
			||||||
            .type = QEMU_OPT_BOOL,
 | 
					 | 
				
			||||||
        },{
 | 
					        },{
 | 
				
			||||||
            .name = "str2",
 | 
					            .name = "str2",
 | 
				
			||||||
            .type = QEMU_OPT_STRING,
 | 
					            .type = QEMU_OPT_STRING,
 | 
				
			||||||
 | 
					        },{
 | 
				
			||||||
 | 
					            .name = "bool1",
 | 
				
			||||||
 | 
					            .type = QEMU_OPT_BOOL,
 | 
				
			||||||
 | 
					        },{
 | 
				
			||||||
 | 
					            .name = "bool2",
 | 
				
			||||||
 | 
					            .type = QEMU_OPT_BOOL,
 | 
				
			||||||
        },{
 | 
					        },{
 | 
				
			||||||
            .name = "size1",
 | 
					            .name = "size1",
 | 
				
			||||||
            .type = QEMU_OPT_SIZE,
 | 
					            .type = QEMU_OPT_SIZE,
 | 
				
			||||||
 | 
					        },{
 | 
				
			||||||
 | 
					            .name = "size2",
 | 
				
			||||||
 | 
					            .type = QEMU_OPT_SIZE,
 | 
				
			||||||
 | 
					        },{
 | 
				
			||||||
 | 
					            .name = "size3",
 | 
				
			||||||
 | 
					            .type = QEMU_OPT_SIZE,
 | 
				
			||||||
        },
 | 
					        },
 | 
				
			||||||
        { /* end of list */ }
 | 
					        { /* end of list */ }
 | 
				
			||||||
    },
 | 
					    },
 | 
				
			||||||
@ -57,6 +70,7 @@ static QemuOptsList opts_list_02 = {
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
static QemuOptsList opts_list_03 = {
 | 
					static QemuOptsList opts_list_03 = {
 | 
				
			||||||
    .name = "opts_list_03",
 | 
					    .name = "opts_list_03",
 | 
				
			||||||
 | 
					    .implied_opt_name = "implied",
 | 
				
			||||||
    .head = QTAILQ_HEAD_INITIALIZER(opts_list_03.head),
 | 
					    .head = QTAILQ_HEAD_INITIALIZER(opts_list_03.head),
 | 
				
			||||||
    .desc = {
 | 
					    .desc = {
 | 
				
			||||||
        /* no elements => accept any params */
 | 
					        /* no elements => accept any params */
 | 
				
			||||||
@ -421,6 +435,314 @@ static void test_qemu_opts_set(void)
 | 
				
			|||||||
    g_assert(opts == NULL);
 | 
					    g_assert(opts == NULL);
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					static int opts_count_iter(void *opaque, const char *name, const char *value,
 | 
				
			||||||
 | 
					                           Error **errp)
 | 
				
			||||||
 | 
					{
 | 
				
			||||||
 | 
					    (*(size_t *)opaque)++;
 | 
				
			||||||
 | 
					    return 0;
 | 
				
			||||||
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					static size_t opts_count(QemuOpts *opts)
 | 
				
			||||||
 | 
					{
 | 
				
			||||||
 | 
					    size_t n = 0;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    qemu_opt_foreach(opts, opts_count_iter, &n, NULL);
 | 
				
			||||||
 | 
					    return n;
 | 
				
			||||||
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					static void test_opts_parse(void)
 | 
				
			||||||
 | 
					{
 | 
				
			||||||
 | 
					    Error *err = NULL;
 | 
				
			||||||
 | 
					    QemuOpts *opts;
 | 
				
			||||||
 | 
					    char long_key[129];
 | 
				
			||||||
 | 
					    char *params;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Nothing */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_03, "", false, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 0);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Empty key */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_03, "=val", false, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 1);
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opt_get(opts, ""), ==, "val");
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Long key */
 | 
				
			||||||
 | 
					    memset(long_key, 'a', 127);
 | 
				
			||||||
 | 
					    long_key[127] = 'z';
 | 
				
			||||||
 | 
					    long_key[128] = 0;
 | 
				
			||||||
 | 
					    params = g_strdup_printf("%s=v", long_key);
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_03, params + 1, NULL, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 1);
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opt_get(opts, long_key + 1), ==, "v");
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Overlong key gets truncated */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_03, params, NULL, &error_abort);
 | 
				
			||||||
 | 
					    g_assert(opts_count(opts) == 1);
 | 
				
			||||||
 | 
					    long_key[127] = 0;
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opt_get(opts, long_key), ==, "v");
 | 
				
			||||||
 | 
					    g_free(params);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Multiple keys, last one wins */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_03, "a=1,b=2,,x,a=3",
 | 
				
			||||||
 | 
					                           false, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 3);
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opt_get(opts, "a"), ==, "3");
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opt_get(opts, "b"), ==, "2,x");
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Except when it doesn't */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_03, "id=foo,id=bar",
 | 
				
			||||||
 | 
					                           false, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 0);
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opts_id(opts), ==, "foo");
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* TODO Cover low-level access to repeated keys */
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Trailing comma is ignored */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_03, "x=y,", false, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 1);
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opt_get(opts, "x"), ==, "y");
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Except when it isn't */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_03, ",", false, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 1);
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opt_get(opts, ""), ==, "on");
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Duplicate ID */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_03, "x=y,id=foo", false, &err);
 | 
				
			||||||
 | 
					    error_free_or_abort(&err);
 | 
				
			||||||
 | 
					    g_assert(!opts);
 | 
				
			||||||
 | 
					    /* TODO Cover .merge_lists = true */
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Buggy ID recognition */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_03, "x=,,id=bar", false, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 1);
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opts_id(opts), ==, "bar"); /* BUG */
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opt_get(opts, "x"), ==, ",id=bar");
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Anti-social ID */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_01, "id=666", false, &err);
 | 
				
			||||||
 | 
					    error_free_or_abort(&err);
 | 
				
			||||||
 | 
					    g_assert(!opts);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Implied value */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_03, "an,noaus,noaus=",
 | 
				
			||||||
 | 
					                           false, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 3);
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opt_get(opts, "an"), ==, "on");
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opt_get(opts, "aus"), ==, "off");
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opt_get(opts, "noaus"), ==, "");
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Implied key */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_03, "an,noaus,noaus=", true,
 | 
				
			||||||
 | 
					                           &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 3);
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opt_get(opts, "implied"), ==, "an");
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opt_get(opts, "aus"), ==, "off");
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opt_get(opts, "noaus"), ==, "");
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Implied key with empty value */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_03, ",", true, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 1);
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opt_get(opts, "implied"), ==, "");
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Implied key with comma value */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_03, ",,,a=1", true, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 2);
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opt_get(opts, "implied"), ==, ",");
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opt_get(opts, "a"), ==, "1");
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Empty key is not an implied key */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_03, "=val", true, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 1);
 | 
				
			||||||
 | 
					    g_assert_cmpstr(qemu_opt_get(opts, ""), ==, "val");
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Unknown key */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_01, "nonexistent=", false, &err);
 | 
				
			||||||
 | 
					    error_free_or_abort(&err);
 | 
				
			||||||
 | 
					    g_assert(!opts);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    qemu_opts_reset(&opts_list_01);
 | 
				
			||||||
 | 
					    qemu_opts_reset(&opts_list_03);
 | 
				
			||||||
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					static void test_opts_parse_bool(void)
 | 
				
			||||||
 | 
					{
 | 
				
			||||||
 | 
					    Error *err = NULL;
 | 
				
			||||||
 | 
					    QemuOpts *opts;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_02, "bool1=on,bool2=off",
 | 
				
			||||||
 | 
					                           false, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 2);
 | 
				
			||||||
 | 
					    g_assert(qemu_opt_get_bool(opts, "bool1", false));
 | 
				
			||||||
 | 
					    g_assert(!qemu_opt_get_bool(opts, "bool2", true));
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_02, "bool1=offer", false, &err);
 | 
				
			||||||
 | 
					    error_free_or_abort(&err);
 | 
				
			||||||
 | 
					    g_assert(!opts);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    qemu_opts_reset(&opts_list_02);
 | 
				
			||||||
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					static void test_opts_parse_number(void)
 | 
				
			||||||
 | 
					{
 | 
				
			||||||
 | 
					    Error *err = NULL;
 | 
				
			||||||
 | 
					    QemuOpts *opts;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Lower limit zero */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_01, "number1=0", false, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 1);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(qemu_opt_get_number(opts, "number1", 1), ==, 0);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Upper limit 2^64-1 */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_01,
 | 
				
			||||||
 | 
					                           "number1=18446744073709551615,number2=-1",
 | 
				
			||||||
 | 
					                           false, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 2);
 | 
				
			||||||
 | 
					    g_assert_cmphex(qemu_opt_get_number(opts, "number1", 1), ==, UINT64_MAX);
 | 
				
			||||||
 | 
					    g_assert_cmphex(qemu_opt_get_number(opts, "number2", 0), ==, UINT64_MAX);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Above upper limit */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_01, "number1=18446744073709551616",
 | 
				
			||||||
 | 
					                           false, &error_abort);
 | 
				
			||||||
 | 
					    /* BUG: should reject */
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 1);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(qemu_opt_get_number(opts, "number1", 1), ==, UINT64_MAX);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Below lower limit */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_01, "number1=-18446744073709551616",
 | 
				
			||||||
 | 
					                           false, &error_abort);
 | 
				
			||||||
 | 
					    /* BUG: should reject */
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 1);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(qemu_opt_get_number(opts, "number1", 1), ==, UINT64_MAX);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Hex and octal */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_01, "number1=0x2a,number2=052",
 | 
				
			||||||
 | 
					                           false, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 2);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(qemu_opt_get_number(opts, "number1", 1), ==, 42);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(qemu_opt_get_number(opts, "number2", 0), ==, 42);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Invalid */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_01, "number1=", false, &err);
 | 
				
			||||||
 | 
					    /* BUG: should reject */
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 1);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(qemu_opt_get_number(opts, "number1", 1), ==, 0);
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_01, "number1=eins", false, &err);
 | 
				
			||||||
 | 
					    error_free_or_abort(&err);
 | 
				
			||||||
 | 
					    g_assert(!opts);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Leading whitespace */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_01, "number1= \t42",
 | 
				
			||||||
 | 
					                           false, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 1);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(qemu_opt_get_number(opts, "number1", 1), ==, 42);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Trailing crap */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_01, "number1=3.14", false, &err);
 | 
				
			||||||
 | 
					    error_free_or_abort(&err);
 | 
				
			||||||
 | 
					    g_assert(!opts);
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_01, "number1=08", false, &err);
 | 
				
			||||||
 | 
					    error_free_or_abort(&err);
 | 
				
			||||||
 | 
					    g_assert(!opts);
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_01, "number1=0 ", false, &err);
 | 
				
			||||||
 | 
					    error_free_or_abort(&err);
 | 
				
			||||||
 | 
					    g_assert(!opts);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    qemu_opts_reset(&opts_list_01);
 | 
				
			||||||
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					static void test_opts_parse_size(void)
 | 
				
			||||||
 | 
					{
 | 
				
			||||||
 | 
					    Error *err = NULL;
 | 
				
			||||||
 | 
					    QemuOpts *opts;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Lower limit zero */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_02, "size1=0", false, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 1);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(qemu_opt_get_size(opts, "size1", 1), ==, 0);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Note: precision is 53 bits since we're parsing with strtod() */
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Around limit of precision: 2^53-1, 2^53, 2^54 */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_02,
 | 
				
			||||||
 | 
					                           "size1=9007199254740991,"
 | 
				
			||||||
 | 
					                           "size2=9007199254740992,"
 | 
				
			||||||
 | 
					                           "size3=9007199254740993",
 | 
				
			||||||
 | 
					                           false, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 3);
 | 
				
			||||||
 | 
					    g_assert_cmphex(qemu_opt_get_size(opts, "size1", 1),
 | 
				
			||||||
 | 
					                     ==, 0x1fffffffffffff);
 | 
				
			||||||
 | 
					    g_assert_cmphex(qemu_opt_get_size(opts, "size2", 1),
 | 
				
			||||||
 | 
					                     ==, 0x20000000000000);
 | 
				
			||||||
 | 
					    g_assert_cmphex(qemu_opt_get_size(opts, "size3", 1),
 | 
				
			||||||
 | 
					                     ==, 0x20000000000000);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Close to signed upper limit 0x7ffffffffffffc00 (53 msbs set) */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_02,
 | 
				
			||||||
 | 
					                           "size1=9223372036854774784," /* 7ffffffffffffc00 */
 | 
				
			||||||
 | 
					                           "size2=9223372036854775295", /* 7ffffffffffffdff */
 | 
				
			||||||
 | 
					                           false, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 2);
 | 
				
			||||||
 | 
					    g_assert_cmphex(qemu_opt_get_size(opts, "size1", 1),
 | 
				
			||||||
 | 
					                     ==, 0x7ffffffffffffc00);
 | 
				
			||||||
 | 
					    g_assert_cmphex(qemu_opt_get_size(opts, "size2", 1),
 | 
				
			||||||
 | 
					                     ==, 0x7ffffffffffffc00);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Close to actual upper limit 0xfffffffffffff800 (53 msbs set) */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_02,
 | 
				
			||||||
 | 
					                           "size1=18446744073709549568," /* fffffffffffff800 */
 | 
				
			||||||
 | 
					                           "size2=18446744073709550591", /* fffffffffffffbff */
 | 
				
			||||||
 | 
					                           false, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 2);
 | 
				
			||||||
 | 
					    g_assert_cmphex(qemu_opt_get_size(opts, "size1", 1),
 | 
				
			||||||
 | 
					                     ==, 0xfffffffffffff800);
 | 
				
			||||||
 | 
					    g_assert_cmphex(qemu_opt_get_size(opts, "size2", 1),
 | 
				
			||||||
 | 
					                     ==, 0xfffffffffffff800);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Beyond limits */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_02, "size1=-1", false, &err);
 | 
				
			||||||
 | 
					    error_free_or_abort(&err);
 | 
				
			||||||
 | 
					    g_assert(!opts);
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_02,
 | 
				
			||||||
 | 
					                           "size1=18446744073709550592", /* fffffffffffffc00 */
 | 
				
			||||||
 | 
					                           false, &error_abort);
 | 
				
			||||||
 | 
					    /* BUG: should reject */
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 1);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(qemu_opt_get_size(opts, "size1", 1), ==, 0);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Suffixes */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_02, "size1=8b,size2=1.5k,size3=2M",
 | 
				
			||||||
 | 
					                           false, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 3);
 | 
				
			||||||
 | 
					    g_assert_cmphex(qemu_opt_get_size(opts, "size1", 0), ==, 8);
 | 
				
			||||||
 | 
					    g_assert_cmphex(qemu_opt_get_size(opts, "size2", 0), ==, 1536);
 | 
				
			||||||
 | 
					    g_assert_cmphex(qemu_opt_get_size(opts, "size3", 0), ==, 2 * M_BYTE);
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_02, "size1=0.1G,size2=16777215T",
 | 
				
			||||||
 | 
					                           false, &error_abort);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 2);
 | 
				
			||||||
 | 
					    g_assert_cmphex(qemu_opt_get_size(opts, "size1", 0), ==, G_BYTE / 10);
 | 
				
			||||||
 | 
					    g_assert_cmphex(qemu_opt_get_size(opts, "size2", 0),
 | 
				
			||||||
 | 
					                     ==, 16777215 * T_BYTE);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Beyond limit with suffix */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_02, "size1=16777216T",
 | 
				
			||||||
 | 
					                           false, &error_abort);
 | 
				
			||||||
 | 
					    /* BUG: should reject */
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 1);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(qemu_opt_get_size(opts, "size1", 1), ==, 0);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    /* Trailing crap */
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_02, "size1=16E", false, &err);
 | 
				
			||||||
 | 
					    error_free_or_abort(&err);
 | 
				
			||||||
 | 
					    g_assert(!opts);
 | 
				
			||||||
 | 
					    opts = qemu_opts_parse(&opts_list_02, "size1=16Gi", false, &error_abort);
 | 
				
			||||||
 | 
					    /* BUG: should reject */
 | 
				
			||||||
 | 
					    g_assert_cmpuint(opts_count(opts), ==, 1);
 | 
				
			||||||
 | 
					    g_assert_cmpuint(qemu_opt_get_size(opts, "size1", 1), ==, 16 * G_BYTE);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    qemu_opts_reset(&opts_list_02);
 | 
				
			||||||
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
int main(int argc, char *argv[])
 | 
					int main(int argc, char *argv[])
 | 
				
			||||||
{
 | 
					{
 | 
				
			||||||
    register_opts();
 | 
					    register_opts();
 | 
				
			||||||
@ -435,6 +757,10 @@ int main(int argc, char *argv[])
 | 
				
			|||||||
    g_test_add_func("/qemu-opts/opt_unset", test_qemu_opt_unset);
 | 
					    g_test_add_func("/qemu-opts/opt_unset", test_qemu_opt_unset);
 | 
				
			||||||
    g_test_add_func("/qemu-opts/opts_reset", test_qemu_opts_reset);
 | 
					    g_test_add_func("/qemu-opts/opts_reset", test_qemu_opts_reset);
 | 
				
			||||||
    g_test_add_func("/qemu-opts/opts_set", test_qemu_opts_set);
 | 
					    g_test_add_func("/qemu-opts/opts_set", test_qemu_opts_set);
 | 
				
			||||||
 | 
					    g_test_add_func("/qemu-opts/opts_parse/general", test_opts_parse);
 | 
				
			||||||
 | 
					    g_test_add_func("/qemu-opts/opts_parse/bool", test_opts_parse_bool);
 | 
				
			||||||
 | 
					    g_test_add_func("/qemu-opts/opts_parse/number", test_opts_parse_number);
 | 
				
			||||||
 | 
					    g_test_add_func("/qemu-opts/opts_parse/size", test_opts_parse_size);
 | 
				
			||||||
    g_test_run();
 | 
					    g_test_run();
 | 
				
			||||||
    return 0;
 | 
					    return 0;
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
				
			|||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user