david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid crash on '-usbdevice <device>' without parameters

Browse Source 
Many usbdevice_init implementors assume params is non-NULL.

Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Jan Kiszka 2010-03-07 12:17:08 +01:00 committed by Anthony Liguori
parent cc39a92cbf
commit 702f3e0fb5
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hw/usb-bus.c
View File

@ -264,7 +264,8 @@ USBDevice *usbdevice_create(const char *cmdline)
USBBus *bus = usb_bus_find(-1 /* any */); USBBus *bus = usb_bus_find(-1 /* any */);
DeviceInfo *info; DeviceInfo *info;
USBDeviceInfo *usb; USBDeviceInfo *usb;
char driver[32], *params; char driver[32];
const char *params;
int len; int len;
params = strchr(cmdline,':'); params = strchr(cmdline,':');
@ -275,6 +276,7 @@ USBDevice *usbdevice_create(const char *cmdline)
len = sizeof(driver); len = sizeof(driver);
pstrcpy(driver, len, cmdline); pstrcpy(driver, len, cmdline);
} else { } else {
params = "";
pstrcpy(driver, sizeof(driver), cmdline); pstrcpy(driver, sizeof(driver), cmdline);
} }