david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

qdev: improve property error reporting.

Browse Source 
Add a error message in case we fail to parse a qdev property.

Also make qemu not abort() in case setting a global property can't be
set.  This used to be a clear programming error.  The introduction of
the -global switch changed that though, so better exit instead (after
printing the new error message).

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Gerd Hoffmann 2009-12-16 14:22:11 +01:00 committed by Anthony Liguori
parent 69fd02eea6
commit 9ef5c4bf81
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
hw/qdev-properties.c
View File

@ -500,7 +500,12 @@ int qdev_prop_parse(DeviceState *dev, const char *name, const char *value)
dev->info->name, name); dev->info->name, name);
return -1; return -1;
} }
return prop->info->parse(dev, prop, value); if (prop->info->parse(dev, prop, value) != 0) {
fprintf(stderr, "property \"%s.%s\": failed to parse \"%s\"\n",
dev->info->name, name, value);
return -1;
}
return 0;
} }
void qdev_prop_set(DeviceState *dev, const char *name, void *src, enum PropertyType type) void qdev_prop_set(DeviceState *dev, const char *name, void *src, enum PropertyType type)
@ -619,7 +624,7 @@ void qdev_prop_set_globals(DeviceState *dev)
continue; continue;
} }
if (qdev_prop_parse(dev, prop->property, prop->value) != 0) { if (qdev_prop_parse(dev, prop->property, prop->value) != 0) {
abort(); exit(1);
} }
} }
} }