david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

vfio-pci: Fix endian issues in vfio_pci_size_rom()

Browse Source 
VFIO is always little endian so do byte swapping of our mask on the
way in and byte swapping of the size on the way out.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Reported-by: Alexey Kardashevskiy <aik@ozlabs.ru>
This commit is contained in:
Alex Williamson 2013-10-04 12:50:51 -06:00
parent 64fa25a0ef
commit b1c50c5f24
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
hw/misc/vfio.c
View File

@ -1141,7 +1141,7 @@ static const MemoryRegionOps vfio_rom_ops = {
static void vfio_pci_size_rom(VFIODevice *vdev) static void vfio_pci_size_rom(VFIODevice *vdev)
{ {
uint32_t orig, size = (uint32_t)PCI_ROM_ADDRESS_MASK; uint32_t orig, size = cpu_to_le32((uint32_t)PCI_ROM_ADDRESS_MASK);
off_t offset = vdev->config_offset + PCI_ROM_ADDRESS; off_t offset = vdev->config_offset + PCI_ROM_ADDRESS;
char name[32]; char name[32];
@ -1163,7 +1163,7 @@ static void vfio_pci_size_rom(VFIODevice *vdev)
return; return;
} }
size = ~(size & PCI_ROM_ADDRESS_MASK) + 1; size = ~(le32_to_cpu(size) & PCI_ROM_ADDRESS_MASK) + 1;
if (!size) { if (!size) {
return; return;