tcg: don't remove op if output needs to be synced to memory
Commit 9c43b68de628a1e2cba556adfb71c17028eb802e do not correctly check for dead outputs when they need to be synced to memory in case of half-dead operations. Fix that by applying the same pattern than for the default case. Tested-by: Stefan Weil <sw@weilnetz.de> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
This commit is contained in:
		
							parent
							
								
									e1e1b25c97
								
							
						
					
					
						commit
						b3a1be87ba
					
				| @ -1329,8 +1329,8 @@ static void tcg_liveness_analysis(TCGContext *s) | ||||
|                the low part.  The result can be optimized to a simple | ||||
|                add or sub.  This happens often for x86_64 guest when the | ||||
|                cpu mode is set to 32 bit.  */ | ||||
|             if (dead_temps[args[1]]) { | ||||
|                 if (dead_temps[args[0]]) { | ||||
|             if (dead_temps[args[1]] && !mem_temps[1]) { | ||||
|                 if (dead_temps[args[0]] && !mem_temps[0]) { | ||||
|                     goto do_remove; | ||||
|                 } | ||||
|                 /* Create the single operation plus nop.  */ | ||||
| @ -1355,8 +1355,8 @@ static void tcg_liveness_analysis(TCGContext *s) | ||||
|             nb_iargs = 2; | ||||
|             nb_oargs = 2; | ||||
|             /* Likewise, test for the high part of the operation dead.  */ | ||||
|             if (dead_temps[args[1]]) { | ||||
|                 if (dead_temps[args[0]]) { | ||||
|             if (dead_temps[args[1]] && !mem_temps[1]) { | ||||
|                 if (dead_temps[args[0]] && !mem_temps[0]) { | ||||
|                     goto do_remove; | ||||
|                 } | ||||
|                 gen_opc_buf[op_index] = op = INDEX_op_mul_i32; | ||||
|  | ||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user
	 Aurelien Jarno
						Aurelien Jarno