cmd: Fix potential NULL pointer dereference
Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
This commit is contained in:
		
							parent
							
								
									81beeec429
								
							
						
					
					
						commit
						ba7806ad92
					
				
							
								
								
									
										11
									
								
								cmd.c
									
									
									
									
									
								
							
							
						
						
									
										11
									
								
								cmd.c
									
									
									
									
									
								
							| @ -47,7 +47,7 @@ compare(const void *a, const void *b) | ||||
| 
 | ||||
| void add_command(const cmdinfo_t *ci) | ||||
| { | ||||
|     cmdtab = realloc((void *)cmdtab, ++ncmds * sizeof(*cmdtab)); | ||||
|     cmdtab = g_realloc((void *)cmdtab, ++ncmds * sizeof(*cmdtab)); | ||||
|     cmdtab[ncmds - 1] = *ci; | ||||
|     qsort(cmdtab, ncmds, sizeof(*cmdtab), compare); | ||||
| } | ||||
| @ -122,12 +122,7 @@ find_command( | ||||
| 
 | ||||
| void add_user_command(char *optarg) | ||||
| { | ||||
|     ncmdline++; | ||||
|     cmdline = realloc(cmdline, ncmdline * sizeof(char *)); | ||||
|     if (!cmdline) { | ||||
|         perror("realloc"); | ||||
|         exit(1); | ||||
|     } | ||||
|     cmdline = g_realloc(cmdline, ++ncmdline * sizeof(char *)); | ||||
|     cmdline[ncmdline-1] = optarg; | ||||
| } | ||||
| 
 | ||||
| @ -190,7 +185,7 @@ void command_loop(void) | ||||
|         doneline(input, v); | ||||
|     } | ||||
|     if (cmdline) { | ||||
|         free(cmdline); | ||||
|         g_free(cmdline); | ||||
|         return; | ||||
|     } | ||||
| 
 | ||||
|  | ||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user
	 Pavel Borzenkov
						Pavel Borzenkov