david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hw/milkymist-softusb: set buffer in softusb_read_{dmem, pmem} error path

Browse Source 
Make sure we set the buffer to something in the softusb_read_{dmem,pmem}
error paths, since the caller will use the buffer unconditionally.
(Newer gcc is smart enough to spot this and complain about 'may be
used uninitialized'.)

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-id: 1364496184-11994-1-git-send-email-peter.maydell@linaro.org
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
Peter Maydell 2013-03-28 18:43:04 +00:00 committed by Anthony Liguori
parent c34e120554
commit c31bc98e3b
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
hw/milkymist-softusb.c
View File

@ -132,6 +132,7 @@ static inline void softusb_read_dmem(MilkymistSoftUsbState *s,
if (offset + len >= s->dmem_size) { if (offset + len >= s->dmem_size) {
error_report("milkymist_softusb: read dmem out of bounds " error_report("milkymist_softusb: read dmem out of bounds "
"at offset 0x%x, len %d", offset, len); "at offset 0x%x, len %d", offset, len);
memset(buf, 0, len);
return; return;
} }
@ -156,6 +157,7 @@ static inline void softusb_read_pmem(MilkymistSoftUsbState *s,
if (offset + len >= s->pmem_size) { if (offset + len >= s->pmem_size) {
error_report("milkymist_softusb: read pmem out of bounds " error_report("milkymist_softusb: read pmem out of bounds "
"at offset 0x%x, len %d", offset, len); "at offset 0x%x, len %d", offset, len);
memset(buf, 0, len);
return; return;
} }