david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

savevm: qemu_savevm_state(): Drop stop VM logic

Browse Source 
qemu_savevm_state() has some logic to stop the VM and to (or not to)
resume it. But this seems to be a big noop, as qemu_savevm_state()
is only called by do_savevm() when the VM is already stopped.

So, let's drop qemu_savevm_state()'s stop VM logic.

Reviewed-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
This commit is contained in:
Luiz Capitulino 2011-10-13 11:36:40 -03:00
parent ee21cb5f1d
commit c370f09dba
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
savevm.c
View File

@ -1599,12 +1599,8 @@ void qemu_savevm_state_cancel(Monitor *mon, QEMUFile *f)
static int qemu_savevm_state(Monitor *mon, QEMUFile *f) static int qemu_savevm_state(Monitor *mon, QEMUFile *f)
{ {
int saved_vm_running;
int ret; int ret;
saved_vm_running = runstate_is_running();
vm_stop(RUN_STATE_SAVE_VM);
if (qemu_savevm_state_blocked(mon)) { if (qemu_savevm_state_blocked(mon)) {
ret = -EINVAL; ret = -EINVAL;
goto out; goto out;
@ -1626,9 +1622,6 @@ out:
if (qemu_file_has_error(f)) if (qemu_file_has_error(f))
ret = -EIO; ret = -EIO;
if (!ret && saved_vm_running)
vm_start();
return ret; return ret;
} }