david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Deprecate the -enable-hax option

Browse Source 
We currently have got three ways of turning on the HAX accelerator:
"-machine accel=hax", "-accel hax" and "-enable-hax". That's really
confusing and overloaded. Since "-accel" is our preferred way to enable
an accelerator nowadays, and "-accel hax" is even less to type than
"-enable-hax", let's deprecate the "-enable-hax" option now.

Note: While "-enable-kvm" is available since a long time and can hardly be
removed since it is used in a lot of upper layer tools and scripts, the
"-enable-hax" option is still rather new and not very widespread yet, so
I think that it should be OK if we remove this in a couple of releases again
(we'll see whether someone complains after seeing the deprecation message -
then we could still reconsider to keep it if there a well-founded reasons).

Signed-off-by: Thomas Huth <thuth@redhat.com>
Message-Id: <1529950933-28347-1-git-send-email-thuth@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
Thomas Huth 2018-06-25 20:22:13 +02:00 committed by Paolo Bonzini
parent a1a98357e3
commit c44df2ff9b
3 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
qemu-doc.texi
View File

@ -2912,6 +2912,11 @@ Option @option{-virtioconsole} has been replaced by
The @code{-clock} option is ignored since QEMU version 1.7.0. There is no The @code{-clock} option is ignored since QEMU version 1.7.0. There is no
replacement since it is not needed anymore. replacement since it is not needed anymore.
@subsection -enable-hax (since 3.0.0)
The @option{-enable-hax} option has been replaced by @option{-accel hax}.
Both options have been introduced in QEMU version 2.9.0.
@section QEMU Machine Protocol (QMP) commands @section QEMU Machine Protocol (QMP) commands
@subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0) @subsection block-dirty-bitmap-add "autoload" parameter (since 2.12.0)

2
qemu-options.hx
View File

@ -3421,7 +3421,7 @@ STEXI
Enable HAX (Hardware-based Acceleration eXecution) support. This option Enable HAX (Hardware-based Acceleration eXecution) support. This option
is only available if HAX support is enabled when compiling. HAX is only is only available if HAX support is enabled when compiling. HAX is only
applicable to MAC and Windows platform, and thus does not conflict with applicable to MAC and Windows platform, and thus does not conflict with
KVM. KVM. This option is deprecated, use @option{-accel hax} instead.
ETEXI ETEXI
DEF("xen-domid", HAS_ARG, QEMU_OPTION_xen_domid, DEF("xen-domid", HAS_ARG, QEMU_OPTION_xen_domid,

1
vl.c
View File

@ -3581,6 +3581,7 @@ int main(int argc, char **argv, char **envp)
qemu_opts_parse_noisily(olist, "accel=kvm", false); qemu_opts_parse_noisily(olist, "accel=kvm", false);
break; break;
case QEMU_OPTION_enable_hax: case QEMU_OPTION_enable_hax:
warn_report("Option is deprecated, use '-accel hax' instead");
olist = qemu_find_opts("machine"); olist = qemu_find_opts("machine");
qemu_opts_parse_noisily(olist, "accel=hax", false); qemu_opts_parse_noisily(olist, "accel=hax", false);
break; break;