david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

monitor: Simplify do_inject_mce() with qemu_get_cpu()

Browse Source 
Avoids an open-coded CPU loop.

Reviewed-by: liguang <lig.fnst@cn.fujitsu.com>
Reviewed-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
This commit is contained in:
Andreas Färber 2013-05-17 16:57:52 +02:00
parent 31ccdde298
commit c51a944b75
1 changed files with 5 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
monitor.c
View File

@ -2013,7 +2013,6 @@ static void do_acl_remove(Monitor *mon, const QDict *qdict)
static void do_inject_mce(Monitor *mon, const QDict *qdict) static void do_inject_mce(Monitor *mon, const QDict *qdict)
{ {
X86CPU *cpu; X86CPU *cpu;
CPUX86State *cenv;
CPUState *cs; CPUState *cs;
int cpu_index = qdict_get_int(qdict, "cpu_index"); int cpu_index = qdict_get_int(qdict, "cpu_index");
int bank = qdict_get_int(qdict, "bank"); int bank = qdict_get_int(qdict, "bank");
@ -2026,14 +2025,11 @@ static void do_inject_mce(Monitor *mon, const QDict *qdict)
if (qdict_get_try_bool(qdict, "broadcast", 0)) { if (qdict_get_try_bool(qdict, "broadcast", 0)) {
flags |= MCE_INJECT_BROADCAST; flags |= MCE_INJECT_BROADCAST;
} }
for (cenv = first_cpu; cenv != NULL; cenv = cenv->next_cpu) { cs = qemu_get_cpu(cpu_index);
cpu = x86_env_get_cpu(cenv); if (cs != NULL) {
cs = CPU(cpu); cpu = X86_CPU(cs);
if (cs->cpu_index == cpu_index) { cpu_x86_inject_mce(mon, cpu, bank, status, mcg_status, addr, misc,
cpu_x86_inject_mce(mon, cpu, bank, status, mcg_status, addr, misc, flags);
flags);
break;
}
} }
} }
#endif #endif