david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix comparison which always returned false

Browse Source 
Comparing an 8 bit value with ~0 does not work as expected.
Replace ~0 by UINT8_MAX in comparison and also in assignment
(and fix coding style, too).

Cc: Gleb Natapov <gleb@redhat.com>
Cc: Anthony Liguori <aliguori@us.ibm.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Signed-off-by: malc <av1474@comtv.ru>
This commit is contained in:
Stefan Weil 2010-06-15 23:03:28 +02:00 committed by malc
parent 167e609af4
commit d2c5efd89f
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
hw/hpet.c
View File

@ -74,7 +74,7 @@ typedef struct HPETState {
uint8_t hpet_id; /* instance id */ uint8_t hpet_id; /* instance id */
} HPETState; } HPETState;
struct hpet_fw_config hpet_cfg = {.count = ~0}; struct hpet_fw_config hpet_cfg = {.count = UINT8_MAX};
static uint32_t hpet_in_legacy_mode(HPETState *s) static uint32_t hpet_in_legacy_mode(HPETState *s)
{ {
@ -682,8 +682,10 @@ static int hpet_init(SysBusDevice *dev)
int i, iomemtype; int i, iomemtype;
HPETTimer *timer; HPETTimer *timer;
if (hpet_cfg.count == ~0) /* first instance */ if (hpet_cfg.count == UINT8_MAX) {
/* first instance */
hpet_cfg.count = 0; hpet_cfg.count = 0;
}
if (hpet_cfg.count == 8) { if (hpet_cfg.count == 8) {
fprintf(stderr, "Only 8 instances of HPET is allowed\n"); fprintf(stderr, "Only 8 instances of HPET is allowed\n");