make sure that we aren't overwriting mc->get_hotplug_handler by accident
Suggested-by: Eduardo Habkost <ehabkost@redhat.com> Signed-off-by: Igor Mammedov <imammedo@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Message-id: 1525691524-32265-5-git-send-email-imammedo@redhat.com Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
This commit is contained in:
		
							parent
							
								
									3b77f6c353
								
							
						
					
					
						commit
						debbdc0018
					
				@ -1669,6 +1669,7 @@ static void virt_machine_class_init(ObjectClass *oc, void *data)
 | 
				
			|||||||
    mc->cpu_index_to_instance_props = virt_cpu_index_to_props;
 | 
					    mc->cpu_index_to_instance_props = virt_cpu_index_to_props;
 | 
				
			||||||
    mc->default_cpu_type = ARM_CPU_TYPE_NAME("cortex-a15");
 | 
					    mc->default_cpu_type = ARM_CPU_TYPE_NAME("cortex-a15");
 | 
				
			||||||
    mc->get_default_cpu_node_id = virt_get_default_cpu_node_id;
 | 
					    mc->get_default_cpu_node_id = virt_get_default_cpu_node_id;
 | 
				
			||||||
 | 
					    assert(!mc->get_hotplug_handler);
 | 
				
			||||||
    mc->get_hotplug_handler = virt_machine_get_hotplug_handler;
 | 
					    mc->get_hotplug_handler = virt_machine_get_hotplug_handler;
 | 
				
			||||||
    hc->plug = virt_machine_device_plug_cb;
 | 
					    hc->plug = virt_machine_device_plug_cb;
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
				
			|||||||
@ -2350,6 +2350,7 @@ static void pc_machine_class_init(ObjectClass *oc, void *data)
 | 
				
			|||||||
    pcmc->acpi_data_size = 0x20000 + 0x8000;
 | 
					    pcmc->acpi_data_size = 0x20000 + 0x8000;
 | 
				
			||||||
    pcmc->save_tsc_khz = true;
 | 
					    pcmc->save_tsc_khz = true;
 | 
				
			||||||
    pcmc->linuxboot_dma_enabled = true;
 | 
					    pcmc->linuxboot_dma_enabled = true;
 | 
				
			||||||
 | 
					    assert(!mc->get_hotplug_handler);
 | 
				
			||||||
    mc->get_hotplug_handler = pc_get_hotpug_handler;
 | 
					    mc->get_hotplug_handler = pc_get_hotpug_handler;
 | 
				
			||||||
    mc->cpu_index_to_instance_props = pc_cpu_index_to_props;
 | 
					    mc->cpu_index_to_instance_props = pc_cpu_index_to_props;
 | 
				
			||||||
    mc->get_default_cpu_node_id = pc_get_default_cpu_node_id;
 | 
					    mc->get_default_cpu_node_id = pc_get_default_cpu_node_id;
 | 
				
			||||||
 | 
				
			|||||||
@ -74,6 +74,7 @@ static void e500plat_machine_class_init(ObjectClass *oc, void *data)
 | 
				
			|||||||
    HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(oc);
 | 
					    HotplugHandlerClass *hc = HOTPLUG_HANDLER_CLASS(oc);
 | 
				
			||||||
    MachineClass *mc = MACHINE_CLASS(oc);
 | 
					    MachineClass *mc = MACHINE_CLASS(oc);
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    assert(!mc->get_hotplug_handler);
 | 
				
			||||||
    mc->get_hotplug_handler = e500plat_machine_get_hotpug_handler;
 | 
					    mc->get_hotplug_handler = e500plat_machine_get_hotpug_handler;
 | 
				
			||||||
    hc->plug = e500plat_machine_device_plug_cb;
 | 
					    hc->plug = e500plat_machine_device_plug_cb;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
				
			|||||||
@ -3980,6 +3980,7 @@ static void spapr_machine_class_init(ObjectClass *oc, void *data)
 | 
				
			|||||||
    mc->kvm_type = spapr_kvm_type;
 | 
					    mc->kvm_type = spapr_kvm_type;
 | 
				
			||||||
    machine_class_allow_dynamic_sysbus_dev(mc, TYPE_SPAPR_PCI_HOST_BRIDGE);
 | 
					    machine_class_allow_dynamic_sysbus_dev(mc, TYPE_SPAPR_PCI_HOST_BRIDGE);
 | 
				
			||||||
    mc->pci_allow_0_address = true;
 | 
					    mc->pci_allow_0_address = true;
 | 
				
			||||||
 | 
					    assert(!mc->get_hotplug_handler);
 | 
				
			||||||
    mc->get_hotplug_handler = spapr_get_hotplug_handler;
 | 
					    mc->get_hotplug_handler = spapr_get_hotplug_handler;
 | 
				
			||||||
    hc->pre_plug = spapr_machine_device_pre_plug;
 | 
					    hc->pre_plug = spapr_machine_device_pre_plug;
 | 
				
			||||||
    hc->plug = spapr_machine_device_plug;
 | 
					    hc->plug = spapr_machine_device_plug;
 | 
				
			||||||
 | 
				
			|||||||
@ -491,6 +491,7 @@ static void ccw_machine_class_init(ObjectClass *oc, void *data)
 | 
				
			|||||||
    mc->no_sdcard = 1;
 | 
					    mc->no_sdcard = 1;
 | 
				
			||||||
    mc->max_cpus = S390_MAX_CPUS;
 | 
					    mc->max_cpus = S390_MAX_CPUS;
 | 
				
			||||||
    mc->has_hotpluggable_cpus = true;
 | 
					    mc->has_hotpluggable_cpus = true;
 | 
				
			||||||
 | 
					    assert(!mc->get_hotplug_handler);
 | 
				
			||||||
    mc->get_hotplug_handler = s390_get_hotplug_handler;
 | 
					    mc->get_hotplug_handler = s390_get_hotplug_handler;
 | 
				
			||||||
    mc->cpu_index_to_instance_props = s390_cpu_index_to_props;
 | 
					    mc->cpu_index_to_instance_props = s390_cpu_index_to_props;
 | 
				
			||||||
    mc->possible_cpu_arch_ids = s390_possible_cpu_arch_ids;
 | 
					    mc->possible_cpu_arch_ids = s390_possible_cpu_arch_ids;
 | 
				
			||||||
 | 
				
			|||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user