david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

hw/ppc/spapr_drc: Replace error_setg(&error_abort) by error_report() + abort()

Browse Source 
Use error_report() + abort() instead of error_setg(&error_abort),
as suggested by the "qapi/error.h" documentation:

    Please don't error_setg(&error_fatal, ...), use error_report() and
    exit(), because that's more obvious.
    Likewise, don't error_setg(&error_abort, ...), use assert().

Use abort() instead of the suggested assert() because the error message
already got displayed.

Suggested-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
This commit is contained in:
Philippe Mathieu-Daudé 2018-05-29 14:48:19 -03:00 committed by David Gibson
parent 45fefe7c4d
commit e20c63140a
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hw/ppc/spapr_drc.c
View File

@ -366,7 +366,8 @@ static void prop_get_fdt(Object *obj, Visitor *v, const char *name,
break; break;
} }
default: default:
error_setg(&error_abort, "device FDT in unexpected state: %d", tag); error_report("device FDT in unexpected state: %d", tag);
abort();
} }
fdt_offset = fdt_offset_next; fdt_offset = fdt_offset_next;
} while (fdt_depth != 0); } while (fdt_depth != 0);