david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

pci: Fix INTx routing notifier recursion

Browse Source 
For some reason we recurse to fire the INTx routing notifier for each
child of a bus, for each possible device of a bus.  That means that if
we add a root port, the notifier gets called for that bridge 256
times.  If we add an upstream switch behind that root port, 256^2.  But
of course we need a downstream switch, 256^3.  This starts to be
noticeable.  Stop the insanity.

Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
This commit is contained in:
Alex Williamson 2013-03-07 11:29:19 -07:00 committed by Michael S. Tsirkin
parent 600d05b9aa
commit e5368f0da7
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
hw/pci/pci.c
View File

@ -1215,10 +1215,11 @@ void pci_bus_fire_intx_routing_notifier(PCIBus *bus)
if (dev && dev->intx_routing_notifier) { if (dev && dev->intx_routing_notifier) {
dev->intx_routing_notifier(dev); dev->intx_routing_notifier(dev);
} }
}
QLIST_FOREACH(sec, &bus->child, sibling) { QLIST_FOREACH(sec, &bus->child, sibling) {
pci_bus_fire_intx_routing_notifier(sec); pci_bus_fire_intx_routing_notifier(sec);
} }
}
} }
void pci_device_set_intx_routing_notifier(PCIDevice *dev, void pci_device_set_intx_routing_notifier(PCIDevice *dev,