david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

migration: Add TODO comments on duplication of QAPI_CLONE()

Browse Source 
qmp_query_migrate_parameters() and qmp_migrate_set_parameters()
effectively duplicate QAPI_CLONE() inline.  Add suitable TODO
comments.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
This commit is contained in:
Markus Armbruster 2017-07-18 12:57:38 +02:00
parent 8cc99dcdc2
commit e87fae4c48
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
migration/migration.c
View File

@ -433,6 +433,7 @@ MigrationParameters *qmp_query_migrate_parameters(Error **errp)
MigrationParameters *params; MigrationParameters *params;
MigrationState *s = migrate_get_current(); MigrationState *s = migrate_get_current();
/* TODO use QAPI_CLONE() instead of duplicating it inline */
params = g_malloc0(sizeof(*params)); params = g_malloc0(sizeof(*params));
params->has_compress_level = true; params->has_compress_level = true;
params->compress_level = s->parameters.compress_level; params->compress_level = s->parameters.compress_level;
@ -745,6 +746,8 @@ static void migrate_params_apply(MigrationParameters *params)
{ {
MigrationState *s = migrate_get_current(); MigrationState *s = migrate_get_current();
/* TODO use QAPI_CLONE() instead of duplicating it inline */
if (params->has_compress_level) { if (params->has_compress_level) {
s->parameters.compress_level = params->compress_level; s->parameters.compress_level = params->compress_level;
} }