david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ide/atapi: Clean up misleading name in cmd_start_stop_unit()

Browse Source 
"eject" is misleading; it means "eject" when start is clear, but
"load" when start is set.  Rename to loej, because that's how MMC-5
calls it, in section 6.40.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
Markus Armbruster 2011-09-06 18:58:37 +02:00 committed by Kevin Wolf
parent 3cfc22692e
commit f077656418
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
hw/ide/atapi.c
View File

@ -903,11 +903,11 @@ static void cmd_seek(IDEState *s, uint8_t* buf)
static void cmd_start_stop_unit(IDEState *s, uint8_t* buf)
{
int start, eject, sense, err = 0;
start = buf[4] & 1;
eject = (buf[4] >> 1) & 1;
int sense, err = 0;
bool start = buf[4] & 1;
bool loej = buf[4] & 2; /* load on start, eject on !start */
if (eject) {
if (loej) {
err = bdrv_eject(s->bs, !start);
}