usb-storage: fix possible memory leak and missing error message
When scsi_bus_legacy_add_drive() return NULL, meanwhile err will be not NULL, which will casue memory leak and missing error message. Cc: Markus Armbruster <armbru@redhat.com> Signed-off-by: Gonglei <arei.gonglei@huawei.com> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
This commit is contained in:
		
							parent
							
								
									31376776d0
								
							
						
					
					
						commit
						f0bc7fe3b7
					
				| @ -624,6 +624,8 @@ static int usb_msd_initfn_storage(USBDevice *dev) | ||||
|                                          s->conf.bootindex, dev->serial, | ||||
|                                          &err); | ||||
|     if (!scsi_dev) { | ||||
|         error_report("%s", error_get_pretty(err)); | ||||
|         error_free(err); | ||||
|         return -1; | ||||
|     } | ||||
|     s->bus.qbus.allow_hotplug = 0; | ||||
|  | ||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user
	 Gonglei
						Gonglei