ich9: call ich9_lpc_update_pic for disabled pirqs
An asserted pirq can be disabled and the corresponding GSIs should then go down to 0. However, because of the conditional in ich9_lpc_update_by_pirq, the legacy 8259 pin could remain stuck to 1. Reviewed-by: Efimov Vasily <real@ispras.ru> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This commit is contained in:
		
							parent
							
								
									f2dd8ebdf4
								
							
						
					
					
						commit
						f62efcacfa
					
				@ -234,9 +234,6 @@ static void ich9_lpc_update_by_pirq(ICH9LPCState *lpc, int pirq)
 | 
				
			|||||||
 | 
					
 | 
				
			||||||
    ich9_lpc_pic_irq(lpc, pirq, &pic_irq, &pic_dis);
 | 
					    ich9_lpc_pic_irq(lpc, pirq, &pic_irq, &pic_dis);
 | 
				
			||||||
    assert(pic_irq < ICH9_LPC_PIC_NUM_PINS);
 | 
					    assert(pic_irq < ICH9_LPC_PIC_NUM_PINS);
 | 
				
			||||||
    if (pic_dis) {
 | 
					 | 
				
			||||||
        return;
 | 
					 | 
				
			||||||
    }
 | 
					 | 
				
			||||||
 | 
					
 | 
				
			||||||
    ich9_lpc_update_pic(lpc, pic_irq);
 | 
					    ich9_lpc_update_pic(lpc, pic_irq);
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
				
			|||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user