virtfs-proxy-helper: fail gracefully if socket path is too long
Replace the assertion check with graceful failure when the socket path is too long. Programs should not crash on invalid input. Print an error message and exit properly. Cc: Shannon Zhao <zhaoshenglong@huawei.com> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
This commit is contained in:
		
							parent
							
								
									bf6667d63e
								
							
						
					
					
						commit
						f8d30a4f96
					
				| @ -739,7 +739,12 @@ static int proxy_socket(const char *path, uid_t uid, gid_t gid) | ||||
|         return -1; | ||||
|     } | ||||
| 
 | ||||
|     g_assert(strlen(path) < sizeof(proxy.sun_path)); | ||||
|     if (strlen(path) >= sizeof(proxy.sun_path)) { | ||||
|         do_log(LOG_CRIT, "UNIX domain socket path exceeds %zu characters\n", | ||||
|                sizeof(proxy.sun_path)); | ||||
|         return -1; | ||||
|     } | ||||
| 
 | ||||
|     sock = socket(AF_UNIX, SOCK_STREAM, 0); | ||||
|     if (sock < 0) { | ||||
|         do_perror("socket"); | ||||
|  | ||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user
	 Stefan Hajnoczi
						Stefan Hajnoczi