tracetool: Forbid argument name 'next'
It has happened more than once that patches that look perfectly sane and work with simpletrace broke systemtap because they use 'next' as an argument name for a tracing function. However, 'next' is a keyword for systemtap, so we shouldn't use it. Signed-off-by: Kevin Wolf <kwolf@redhat.com>
This commit is contained in:
		
							parent
							
								
									bfe24e1a26
								
							
						
					
					
						commit
						fa6b8733c9
					
				@ -81,6 +81,10 @@ get_args()
 | 
				
			|||||||
    args=${1#*\(}
 | 
					    args=${1#*\(}
 | 
				
			||||||
    args=${args%%\)*}
 | 
					    args=${args%%\)*}
 | 
				
			||||||
    echo "$args"
 | 
					    echo "$args"
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    if (echo "$args" | grep "[ *]next\($\|[, ]\)" > /dev/null 2>&1); then
 | 
				
			||||||
 | 
					        echo -e "\n#error 'next' is a bad argument name (clash with systemtap keyword)\n "
 | 
				
			||||||
 | 
					    fi
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
# Get the argument name list of a trace event
 | 
					# Get the argument name list of a trace event
 | 
				
			||||||
 | 
				
			|||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user