david.venhoff/QEMU-Nyx-fork
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

xen/pt: Log xen_host_pci_get/set errors in MSI code.

Browse Source 
We seem to only use these functions when de-activating the
MSI - so just log errors.

Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
This commit is contained in:
Konrad Rzeszutek Wilk 2015-06-24 17:27:40 -04:00 committed by Stefano Stabellini
parent ea6c50f99d
commit fe2da64c5a
1 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
hw/xen/xen_pt_msi.c
View File

@ -75,19 +75,29 @@ static int msi_msix_enable(XenPCIPassthroughState *s,
bool enable) bool enable)
{ {
uint16_t val = 0; uint16_t val = 0;
int rc;
if (!address) { if (!address) {
return -1; return -1;
} }
xen_host_pci_get_word(&s->real_device, address, &val); rc = xen_host_pci_get_word(&s->real_device, address, &val);
if (rc) {
XEN_PT_ERR(&s->dev, "Failed to read MSI/MSI-X register (0x%x), rc:%d\n",
address, rc);
return rc;
}
if (enable) { if (enable) {
val |= flag; val |= flag;
} else { } else {
val &= ~flag; val &= ~flag;
} }
xen_host_pci_set_word(&s->real_device, address, val); rc = xen_host_pci_set_word(&s->real_device, address, val);
return 0; if (rc) {
XEN_PT_ERR(&s->dev, "Failed to write MSI/MSI-X register (0x%x), rc:%d\n",
address, rc);
}
return rc;
} }
static int msi_msix_setup(XenPCIPassthroughState *s, static int msi_msix_setup(XenPCIPassthroughState *s,
@ -276,7 +286,7 @@ void xen_pt_msi_disable(XenPCIPassthroughState *s)
return; return;
} }
xen_pt_msi_set_enable(s, false); (void)xen_pt_msi_set_enable(s, false);
msi_msix_disable(s, msi_addr64(msi), msi->data, msi->pirq, false, msi_msix_disable(s, msi_addr64(msi), msi->data, msi->pirq, false,
msi->initialized); msi->initialized);