Monitor: Convert do_physical_memory_save() to cmd_new_ret()
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
This commit is contained in:
		
							parent
							
								
									9869622ee8
								
							
						
					
					
						commit
						fe38a32acc
					
				@ -1466,7 +1466,7 @@ exit:
 | 
				
			|||||||
    return ret;
 | 
					    return ret;
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
static void do_physical_memory_save(Monitor *mon, const QDict *qdict,
 | 
					static int do_physical_memory_save(Monitor *mon, const QDict *qdict,
 | 
				
			||||||
                                    QObject **ret_data)
 | 
					                                    QObject **ret_data)
 | 
				
			||||||
{
 | 
					{
 | 
				
			||||||
    FILE *f;
 | 
					    FILE *f;
 | 
				
			||||||
@ -1475,11 +1475,12 @@ static void do_physical_memory_save(Monitor *mon, const QDict *qdict,
 | 
				
			|||||||
    uint32_t size = qdict_get_int(qdict, "size");
 | 
					    uint32_t size = qdict_get_int(qdict, "size");
 | 
				
			||||||
    const char *filename = qdict_get_str(qdict, "filename");
 | 
					    const char *filename = qdict_get_str(qdict, "filename");
 | 
				
			||||||
    target_phys_addr_t addr = qdict_get_int(qdict, "val");
 | 
					    target_phys_addr_t addr = qdict_get_int(qdict, "val");
 | 
				
			||||||
 | 
					    int ret = -1;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
    f = fopen(filename, "wb");
 | 
					    f = fopen(filename, "wb");
 | 
				
			||||||
    if (!f) {
 | 
					    if (!f) {
 | 
				
			||||||
        qemu_error_new(QERR_OPEN_FILE_FAILED, filename);
 | 
					        qemu_error_new(QERR_OPEN_FILE_FAILED, filename);
 | 
				
			||||||
        return;
 | 
					        return -1;
 | 
				
			||||||
    }
 | 
					    }
 | 
				
			||||||
    while (size != 0) {
 | 
					    while (size != 0) {
 | 
				
			||||||
        l = sizeof(buf);
 | 
					        l = sizeof(buf);
 | 
				
			||||||
@ -1494,8 +1495,12 @@ static void do_physical_memory_save(Monitor *mon, const QDict *qdict,
 | 
				
			|||||||
        addr += l;
 | 
					        addr += l;
 | 
				
			||||||
        size -= l;
 | 
					        size -= l;
 | 
				
			||||||
    }
 | 
					    }
 | 
				
			||||||
 | 
					
 | 
				
			||||||
 | 
					    ret = 0;
 | 
				
			||||||
 | 
					
 | 
				
			||||||
exit:
 | 
					exit:
 | 
				
			||||||
    fclose(f);
 | 
					    fclose(f);
 | 
				
			||||||
 | 
					    return ret;
 | 
				
			||||||
}
 | 
					}
 | 
				
			||||||
 | 
					
 | 
				
			||||||
static void do_sum(Monitor *mon, const QDict *qdict)
 | 
					static void do_sum(Monitor *mon, const QDict *qdict)
 | 
				
			||||||
 | 
				
			|||||||
@ -720,7 +720,7 @@ ETEXI
 | 
				
			|||||||
        .params     = "addr size file",
 | 
					        .params     = "addr size file",
 | 
				
			||||||
        .help       = "save to disk physical memory dump starting at 'addr' of size 'size'",
 | 
					        .help       = "save to disk physical memory dump starting at 'addr' of size 'size'",
 | 
				
			||||||
        .user_print = monitor_user_noop,
 | 
					        .user_print = monitor_user_noop,
 | 
				
			||||||
        .mhandler.cmd_new = do_physical_memory_save,
 | 
					        .cmd_new_ret = do_physical_memory_save,
 | 
				
			||||||
    },
 | 
					    },
 | 
				
			||||||
 | 
					
 | 
				
			||||||
STEXI
 | 
					STEXI
 | 
				
			||||||
 | 
				
			|||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user