Calling error_report() from within a function that takes an Error ** argument is suspicious. qemu_fsdev_add() does that, and its caller fsdev_init_func() then fails without setting an error. Its caller main(), via qemu_opts_foreach(), is fine with it, but clean it up anyway. Cc: Greg Kurz <groug@kaod.org> Signed-off-by: Markus Armbruster <armbru@redhat.com> Acked-by: Greg Kurz <groug@kaod.org> Message-Id: <20181017082702.5581-32-armbru@redhat.com>
		
			
				
	
	
		
			48 lines
		
	
	
		
			985 B
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			48 lines
		
	
	
		
			985 B
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * 9p
 | 
						|
 *
 | 
						|
 * Copyright IBM, Corp. 2010
 | 
						|
 *
 | 
						|
 * Authors:
 | 
						|
 *  Gautham R Shenoy <ego@in.ibm.com>
 | 
						|
 *
 | 
						|
 * This work is licensed under the terms of the GNU GPL, version 2.  See
 | 
						|
 * the COPYING file in the top-level directory.
 | 
						|
 *
 | 
						|
 */
 | 
						|
#ifndef QEMU_FSDEV_H
 | 
						|
#define QEMU_FSDEV_H
 | 
						|
#include "file-op-9p.h"
 | 
						|
 | 
						|
 | 
						|
/*
 | 
						|
 * A table to store the various file systems and their callback operations.
 | 
						|
 * -----------------
 | 
						|
 * fstype | ops
 | 
						|
 * -----------------
 | 
						|
 *  local | local_ops
 | 
						|
 *  .     |
 | 
						|
 *  .     |
 | 
						|
 *  .     |
 | 
						|
 *  .     |
 | 
						|
 * -----------------
 | 
						|
 *  etc
 | 
						|
 */
 | 
						|
typedef struct FsDriverTable {
 | 
						|
    const char *name;
 | 
						|
    FileOperations *ops;
 | 
						|
} FsDriverTable;
 | 
						|
 | 
						|
typedef struct FsDriverListEntry {
 | 
						|
    FsDriverEntry fse;
 | 
						|
    QTAILQ_ENTRY(FsDriverListEntry) next;
 | 
						|
} FsDriverListEntry;
 | 
						|
 | 
						|
int qemu_fsdev_add(QemuOpts *opts, Error **errp);
 | 
						|
FsDriverEntry *get_fsdev_fsentry(char *id);
 | 
						|
extern FileOperations local_ops;
 | 
						|
extern FileOperations handle_ops;
 | 
						|
extern FileOperations synth_ops;
 | 
						|
extern FileOperations proxy_ops;
 | 
						|
#endif
 |