Unlike other object_property_add_link() occurrences in virtio devices, virtio-crypto checks the "in use" state of the linked backend object in addition to qdev_prop_allow_set_link_before_realize. To convert it without needing to specialize DEFINE_PROP_LINK which always uses the qdev callback, move the "in use" check to device realize time. Signed-off-by: Fam Zheng <famz@redhat.com> Message-Id: <20170714021509.23681-10-famz@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
		
			
				
	
	
		
			80 lines
		
	
	
		
			2.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			80 lines
		
	
	
		
			2.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * Virtio crypto device
 | 
						|
 *
 | 
						|
 * Copyright (c) 2016 HUAWEI TECHNOLOGIES CO., LTD.
 | 
						|
 *
 | 
						|
 * Authors:
 | 
						|
 *    Gonglei <arei.gonglei@huawei.com>
 | 
						|
 *
 | 
						|
 * This work is licensed under the terms of the GNU GPL, version 2 or
 | 
						|
 * (at your option) any later version.  See the COPYING file in the
 | 
						|
 * top-level directory.
 | 
						|
 *
 | 
						|
 */
 | 
						|
#include "qemu/osdep.h"
 | 
						|
#include "hw/pci/pci.h"
 | 
						|
#include "hw/virtio/virtio.h"
 | 
						|
#include "hw/virtio/virtio-bus.h"
 | 
						|
#include "hw/virtio/virtio-pci.h"
 | 
						|
#include "hw/virtio/virtio-crypto.h"
 | 
						|
#include "qapi/error.h"
 | 
						|
 | 
						|
static Property virtio_crypto_pci_properties[] = {
 | 
						|
    DEFINE_PROP_BIT("ioeventfd", VirtIOPCIProxy, flags,
 | 
						|
                    VIRTIO_PCI_FLAG_USE_IOEVENTFD_BIT, true),
 | 
						|
    DEFINE_PROP_UINT32("vectors", VirtIOPCIProxy, nvectors, 2),
 | 
						|
    DEFINE_PROP_END_OF_LIST(),
 | 
						|
};
 | 
						|
 | 
						|
static void virtio_crypto_pci_realize(VirtIOPCIProxy *vpci_dev, Error **errp)
 | 
						|
{
 | 
						|
    VirtIOCryptoPCI *vcrypto = VIRTIO_CRYPTO_PCI(vpci_dev);
 | 
						|
    DeviceState *vdev = DEVICE(&vcrypto->vdev);
 | 
						|
 | 
						|
    if (vcrypto->vdev.conf.cryptodev == NULL) {
 | 
						|
        error_setg(errp, "'cryptodev' parameter expects a valid object");
 | 
						|
        return;
 | 
						|
    }
 | 
						|
 | 
						|
    qdev_set_parent_bus(vdev, BUS(&vpci_dev->bus));
 | 
						|
    virtio_pci_force_virtio_1(vpci_dev);
 | 
						|
    object_property_set_bool(OBJECT(vdev), true, "realized", errp);
 | 
						|
    object_property_set_link(OBJECT(vcrypto),
 | 
						|
                 OBJECT(vcrypto->vdev.conf.cryptodev), "cryptodev",
 | 
						|
                 NULL);
 | 
						|
}
 | 
						|
 | 
						|
static void virtio_crypto_pci_class_init(ObjectClass *klass, void *data)
 | 
						|
{
 | 
						|
    DeviceClass *dc = DEVICE_CLASS(klass);
 | 
						|
    VirtioPCIClass *k = VIRTIO_PCI_CLASS(klass);
 | 
						|
    PCIDeviceClass *pcidev_k = PCI_DEVICE_CLASS(klass);
 | 
						|
 | 
						|
    k->realize = virtio_crypto_pci_realize;
 | 
						|
    set_bit(DEVICE_CATEGORY_MISC, dc->categories);
 | 
						|
    dc->props = virtio_crypto_pci_properties;
 | 
						|
    pcidev_k->class_id = PCI_CLASS_OTHERS;
 | 
						|
}
 | 
						|
 | 
						|
static void virtio_crypto_initfn(Object *obj)
 | 
						|
{
 | 
						|
    VirtIOCryptoPCI *dev = VIRTIO_CRYPTO_PCI(obj);
 | 
						|
 | 
						|
    virtio_instance_init_common(obj, &dev->vdev, sizeof(dev->vdev),
 | 
						|
                                TYPE_VIRTIO_CRYPTO);
 | 
						|
}
 | 
						|
 | 
						|
static const TypeInfo virtio_crypto_pci_info = {
 | 
						|
    .name          = TYPE_VIRTIO_CRYPTO_PCI,
 | 
						|
    .parent        = TYPE_VIRTIO_PCI,
 | 
						|
    .instance_size = sizeof(VirtIOCryptoPCI),
 | 
						|
    .instance_init = virtio_crypto_initfn,
 | 
						|
    .class_init    = virtio_crypto_pci_class_init,
 | 
						|
};
 | 
						|
 | 
						|
static void virtio_crypto_pci_register_types(void)
 | 
						|
{
 | 
						|
    type_register_static(&virtio_crypto_pci_info);
 | 
						|
}
 | 
						|
type_init(virtio_crypto_pci_register_types)
 |