The pxe-test is run for three different targets now (x86_64, i386 and ppc64), and the bios-tables-test is run for two targets (x86_64 and i386). But each of the tests is using an invariant name for the disk image with the boot sector code - so if the tests are running in parallel, there is a race condition that they destroy the disk image of a parallel test program. Let's use mkstemp() to create unique temporary files here instead - and since mkstemp() is returning an integer file descriptor instead of a FILE pointer, we also switch the fwrite() and fclose() to write() and close() instead. Reported-by: Sascha Silbe <x-qemu@se-silbe.de> Signed-off-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
		
			
				
	
	
		
			76 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			76 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * PXE test cases.
 | 
						|
 *
 | 
						|
 * Copyright (c) 2016 Red Hat Inc.
 | 
						|
 *
 | 
						|
 * Authors:
 | 
						|
 *  Michael S. Tsirkin <mst@redhat.com>,
 | 
						|
 *  Victor Kaplansky <victork@redhat.com>
 | 
						|
 *
 | 
						|
 * This work is licensed under the terms of the GNU GPL, version 2 or later.
 | 
						|
 * See the COPYING file in the top-level directory.
 | 
						|
 */
 | 
						|
 | 
						|
#include "qemu/osdep.h"
 | 
						|
#include <glib/gstdio.h>
 | 
						|
#include "qemu-common.h"
 | 
						|
#include "libqtest.h"
 | 
						|
#include "boot-sector.h"
 | 
						|
 | 
						|
#define NETNAME "net0"
 | 
						|
 | 
						|
static char disk[] = "tests/pxe-test-disk-XXXXXX";
 | 
						|
 | 
						|
static void test_pxe_one(const char *params, bool ipv6)
 | 
						|
{
 | 
						|
    char *args;
 | 
						|
 | 
						|
    args = g_strdup_printf("-machine accel=tcg -nodefaults -boot order=n "
 | 
						|
                           "-netdev user,id=" NETNAME ",tftp=./,bootfile=%s,"
 | 
						|
                           "ipv4=%s,ipv6=%s %s", disk, ipv6 ? "off" : "on",
 | 
						|
                           ipv6 ? "on" : "off", params);
 | 
						|
 | 
						|
    qtest_start(args);
 | 
						|
    boot_sector_test();
 | 
						|
    qtest_quit(global_qtest);
 | 
						|
    g_free(args);
 | 
						|
}
 | 
						|
 | 
						|
static void test_pxe_e1000(void)
 | 
						|
{
 | 
						|
    test_pxe_one("-device e1000,netdev=" NETNAME, false);
 | 
						|
}
 | 
						|
 | 
						|
static void test_pxe_virtio_pci(void)
 | 
						|
{
 | 
						|
    test_pxe_one("-device virtio-net-pci,netdev=" NETNAME, false);
 | 
						|
}
 | 
						|
 | 
						|
static void test_pxe_spapr_vlan(void)
 | 
						|
{
 | 
						|
    test_pxe_one("-device spapr-vlan,netdev=" NETNAME, true);
 | 
						|
}
 | 
						|
 | 
						|
int main(int argc, char *argv[])
 | 
						|
{
 | 
						|
    int ret;
 | 
						|
    const char *arch = qtest_get_arch();
 | 
						|
 | 
						|
    ret = boot_sector_init(disk);
 | 
						|
    if(ret)
 | 
						|
        return ret;
 | 
						|
 | 
						|
    g_test_init(&argc, &argv, NULL);
 | 
						|
 | 
						|
    if (strcmp(arch, "i386") == 0 || strcmp(arch, "x86_64") == 0) {
 | 
						|
        qtest_add_func("pxe/e1000", test_pxe_e1000);
 | 
						|
        qtest_add_func("pxe/virtio", test_pxe_virtio_pci);
 | 
						|
    } else if (strcmp(arch, "ppc64") == 0) {
 | 
						|
        qtest_add_func("pxe/virtio", test_pxe_virtio_pci);
 | 
						|
        qtest_add_func("pxe/spapr-vlan", test_pxe_spapr_vlan);
 | 
						|
    }
 | 
						|
    ret = g_test_run();
 | 
						|
    boot_sector_cleanup(disk);
 | 
						|
    return ret;
 | 
						|
}
 |