Make's multiple output syntax
  x.c x.h: x.template
       gen < x.template
actually invokes the command once for x.c and once for x.h (with differing $@
in each invocation).  During a parallel build, the two commands may be invoked
in parallel; this opens up a race, where the second invocation trashes a file
supposedly produced during the first, and now in use by a dependent command.
The various qapi code generators are susceptible to this; fix by making them
generate just one file per invocation.
Signed-off-by: Avi Kivity <avi@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
		
	
			
		
			
				
	
	
		
			268 lines
		
	
	
		
			6.5 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
			
		
		
	
	
			268 lines
		
	
	
		
			6.5 KiB
		
	
	
	
		
			Python
		
	
	
	
	
	
#
 | 
						|
# QAPI visitor generator
 | 
						|
#
 | 
						|
# Copyright IBM, Corp. 2011
 | 
						|
#
 | 
						|
# Authors:
 | 
						|
#  Anthony Liguori <aliguori@us.ibm.com>
 | 
						|
#  Michael Roth    <mdroth@linux.vnet.ibm.com>
 | 
						|
#
 | 
						|
# This work is licensed under the terms of the GNU GPLv2.
 | 
						|
# See the COPYING.LIB file in the top-level directory.
 | 
						|
 | 
						|
from ordereddict import OrderedDict
 | 
						|
from qapi import *
 | 
						|
import sys
 | 
						|
import os
 | 
						|
import getopt
 | 
						|
import errno
 | 
						|
 | 
						|
def generate_visit_struct_body(field_prefix, members):
 | 
						|
    ret = ""
 | 
						|
    if len(field_prefix):
 | 
						|
        field_prefix = field_prefix + "."
 | 
						|
    for argname, argentry, optional, structured in parse_args(members):
 | 
						|
        if optional:
 | 
						|
            ret += mcgen('''
 | 
						|
visit_start_optional(m, (obj && *obj) ? &(*obj)->%(c_prefix)shas_%(c_name)s : NULL, "%(name)s", errp);
 | 
						|
if ((*obj)->%(prefix)shas_%(c_name)s) {
 | 
						|
''',
 | 
						|
                         c_prefix=c_var(field_prefix), prefix=field_prefix,
 | 
						|
                         c_name=c_var(argname), name=argname)
 | 
						|
            push_indent()
 | 
						|
 | 
						|
        if structured:
 | 
						|
            ret += mcgen('''
 | 
						|
visit_start_struct(m, NULL, "", "%(name)s", 0, errp);
 | 
						|
''',
 | 
						|
                         name=argname)
 | 
						|
            ret += generate_visit_struct_body(field_prefix + argname, argentry)
 | 
						|
            ret += mcgen('''
 | 
						|
visit_end_struct(m, errp);
 | 
						|
''')
 | 
						|
        else:
 | 
						|
            ret += mcgen('''
 | 
						|
visit_type_%(type)s(m, (obj && *obj) ? &(*obj)->%(c_prefix)s%(c_name)s : NULL, "%(name)s", errp);
 | 
						|
''',
 | 
						|
                         c_prefix=c_var(field_prefix), prefix=field_prefix,
 | 
						|
                         type=type_name(argentry), c_name=c_var(argname),
 | 
						|
                         name=argname)
 | 
						|
 | 
						|
        if optional:
 | 
						|
            pop_indent()
 | 
						|
            ret += mcgen('''
 | 
						|
}
 | 
						|
visit_end_optional(m, errp);
 | 
						|
''')
 | 
						|
    return ret
 | 
						|
 | 
						|
def generate_visit_struct(name, members):
 | 
						|
    ret = mcgen('''
 | 
						|
 | 
						|
void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error **errp)
 | 
						|
{
 | 
						|
    visit_start_struct(m, (void **)obj, "%(name)s", name, sizeof(%(name)s), errp);
 | 
						|
''',
 | 
						|
                name=name)
 | 
						|
    push_indent()
 | 
						|
    ret += generate_visit_struct_body("", members)
 | 
						|
    pop_indent()
 | 
						|
 | 
						|
    ret += mcgen('''
 | 
						|
    visit_end_struct(m, errp);
 | 
						|
}
 | 
						|
''')
 | 
						|
    return ret
 | 
						|
 | 
						|
def generate_visit_list(name, members):
 | 
						|
    return mcgen('''
 | 
						|
 | 
						|
void visit_type_%(name)sList(Visitor *m, %(name)sList ** obj, const char *name, Error **errp)
 | 
						|
{
 | 
						|
    GenericList *i, **head = (GenericList **)obj;
 | 
						|
 | 
						|
    visit_start_list(m, name, errp);
 | 
						|
 | 
						|
    for (*head = i = visit_next_list(m, head, errp); i; i = visit_next_list(m, &i, errp)) {
 | 
						|
        %(name)sList *native_i = (%(name)sList *)i;
 | 
						|
        visit_type_%(name)s(m, &native_i->value, NULL, errp);
 | 
						|
    }
 | 
						|
 | 
						|
    visit_end_list(m, errp);
 | 
						|
}
 | 
						|
''',
 | 
						|
                name=name)
 | 
						|
 | 
						|
def generate_visit_enum(name, members):
 | 
						|
    return mcgen('''
 | 
						|
 | 
						|
void visit_type_%(name)s(Visitor *m, %(name)s * obj, const char *name, Error **errp)
 | 
						|
{
 | 
						|
    visit_type_enum(m, (int *)obj, %(name)s_lookup, "%(name)s", name, errp);
 | 
						|
}
 | 
						|
''',
 | 
						|
                 name=name)
 | 
						|
 | 
						|
def generate_visit_union(name, members):
 | 
						|
    ret = generate_visit_enum('%sKind' % name, members.keys())
 | 
						|
 | 
						|
    ret += mcgen('''
 | 
						|
 | 
						|
void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error **errp)
 | 
						|
{
 | 
						|
}
 | 
						|
''',
 | 
						|
                 name=name)
 | 
						|
 | 
						|
    return ret
 | 
						|
 | 
						|
def generate_declaration(name, members, genlist=True):
 | 
						|
    ret = mcgen('''
 | 
						|
 | 
						|
void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error **errp);
 | 
						|
''',
 | 
						|
                name=name)
 | 
						|
 | 
						|
    if genlist:
 | 
						|
        ret += mcgen('''
 | 
						|
void visit_type_%(name)sList(Visitor *m, %(name)sList ** obj, const char *name, Error **errp);
 | 
						|
''',
 | 
						|
                 name=name)
 | 
						|
 | 
						|
    return ret
 | 
						|
 | 
						|
def generate_decl_enum(name, members, genlist=True):
 | 
						|
    return mcgen('''
 | 
						|
 | 
						|
void visit_type_%(name)s(Visitor *m, %(name)s * obj, const char *name, Error **errp);
 | 
						|
''',
 | 
						|
                name=name)
 | 
						|
 | 
						|
try:
 | 
						|
    opts, args = getopt.gnu_getopt(sys.argv[1:], "chp:o:",
 | 
						|
                                   ["source", "header", "prefix=", "output-dir="])
 | 
						|
except getopt.GetoptError, err:
 | 
						|
    print str(err)
 | 
						|
    sys.exit(1)
 | 
						|
 | 
						|
output_dir = ""
 | 
						|
prefix = ""
 | 
						|
c_file = 'qapi-visit.c'
 | 
						|
h_file = 'qapi-visit.h'
 | 
						|
 | 
						|
do_c = False
 | 
						|
do_h = False
 | 
						|
 | 
						|
for o, a in opts:
 | 
						|
    if o in ("-p", "--prefix"):
 | 
						|
        prefix = a
 | 
						|
    elif o in ("-o", "--output-dir"):
 | 
						|
        output_dir = a + "/"
 | 
						|
    elif o in ("-c", "--source"):
 | 
						|
        do_h = True
 | 
						|
    elif o in ("-h", "--header"):
 | 
						|
        do_c = True
 | 
						|
 | 
						|
if not do_c and not do_h:
 | 
						|
    do_c = True
 | 
						|
    do_h = True
 | 
						|
 | 
						|
c_file = output_dir + prefix + c_file
 | 
						|
h_file = output_dir + prefix + h_file
 | 
						|
 | 
						|
try:
 | 
						|
    os.makedirs(output_dir)
 | 
						|
except os.error, e:
 | 
						|
    if e.errno != errno.EEXIST:
 | 
						|
        raise
 | 
						|
 | 
						|
def maybe_open(really, name, opt):
 | 
						|
    class Null(object):
 | 
						|
        def write(self, str):
 | 
						|
            pass
 | 
						|
        def read(self):
 | 
						|
            return ''
 | 
						|
    if really:
 | 
						|
        return open(name, opt)
 | 
						|
 | 
						|
fdef = maybe_open(do_c, c_file, 'w')
 | 
						|
fdecl = maybe_open(do_h, h_file, 'w')
 | 
						|
 | 
						|
fdef.write(mcgen('''
 | 
						|
/* THIS FILE IS AUTOMATICALLY GENERATED, DO NOT MODIFY */
 | 
						|
 | 
						|
/*
 | 
						|
 * schema-defined QAPI visitor functions
 | 
						|
 *
 | 
						|
 * Copyright IBM, Corp. 2011
 | 
						|
 *
 | 
						|
 * Authors:
 | 
						|
 *  Anthony Liguori   <aliguori@us.ibm.com>
 | 
						|
 *
 | 
						|
 * This work is licensed under the terms of the GNU LGPL, version 2.1 or later.
 | 
						|
 * See the COPYING.LIB file in the top-level directory.
 | 
						|
 *
 | 
						|
 */
 | 
						|
 | 
						|
#include "%(header)s"
 | 
						|
''',
 | 
						|
                 header=basename(h_file)))
 | 
						|
 | 
						|
fdecl.write(mcgen('''
 | 
						|
/* THIS FILE IS AUTOMATICALLY GENERATED, DO NOT MODIFY */
 | 
						|
 | 
						|
/*
 | 
						|
 * schema-defined QAPI visitor function
 | 
						|
 *
 | 
						|
 * Copyright IBM, Corp. 2011
 | 
						|
 *
 | 
						|
 * Authors:
 | 
						|
 *  Anthony Liguori   <aliguori@us.ibm.com>
 | 
						|
 *
 | 
						|
 * This work is licensed under the terms of the GNU LGPL, version 2.1 or later.
 | 
						|
 * See the COPYING.LIB file in the top-level directory.
 | 
						|
 *
 | 
						|
 */
 | 
						|
 | 
						|
#ifndef %(guard)s
 | 
						|
#define %(guard)s
 | 
						|
 | 
						|
#include "qapi/qapi-visit-core.h"
 | 
						|
#include "%(prefix)sqapi-types.h"
 | 
						|
''',
 | 
						|
                  prefix=prefix, guard=guardname(h_file)))
 | 
						|
 | 
						|
exprs = parse_schema(sys.stdin)
 | 
						|
 | 
						|
for expr in exprs:
 | 
						|
    if expr.has_key('type'):
 | 
						|
        ret = generate_visit_struct(expr['type'], expr['data'])
 | 
						|
        ret += generate_visit_list(expr['type'], expr['data'])
 | 
						|
        fdef.write(ret)
 | 
						|
 | 
						|
        ret = generate_declaration(expr['type'], expr['data'])
 | 
						|
        fdecl.write(ret)
 | 
						|
    elif expr.has_key('union'):
 | 
						|
        ret = generate_visit_union(expr['union'], expr['data'])
 | 
						|
        fdef.write(ret)
 | 
						|
 | 
						|
        ret = generate_decl_enum('%sKind' % expr['union'], expr['data'].keys())
 | 
						|
        ret += generate_declaration(expr['union'], expr['data'])
 | 
						|
        fdecl.write(ret)
 | 
						|
    elif expr.has_key('enum'):
 | 
						|
        ret = generate_visit_enum(expr['enum'], expr['data'])
 | 
						|
        fdef.write(ret)
 | 
						|
 | 
						|
        ret = generate_decl_enum(expr['enum'], expr['data'])
 | 
						|
        fdecl.write(ret)
 | 
						|
 | 
						|
fdecl.write('''
 | 
						|
#endif
 | 
						|
''')
 | 
						|
 | 
						|
fdecl.flush()
 | 
						|
fdecl.close()
 | 
						|
 | 
						|
fdef.flush()
 | 
						|
fdef.close()
 |