QEMU-Nyx-fork

Go to file

Eduardo Habkost 8f302cb090 vl.c: Fix off-by-one bug when handling "-numa node" argument

The numa_add() code was unconditionally adding 1 to the get_opt_name()
return value, making it point after the end of the string if no ','
separator is present.

Example of weird behavior caused by the bug:

  $ qemu-img create -f qcow2 this-file-image-has,cpus=5,mem=1000,in-its-name.qcow2 5G
  Formatting 'this-file-image-has,cpus=5,mem=1000,in-its-name.qcow2', fmt=qcow2 size=5368709120 encryption=off cluster_size=65536
  $ ./x86_64-softmmu/qemu-system-x86_64 -S -monitor stdio -numa node 'this-file-image-has,cpus=5,mem=1000,in-its-name.qcow2'
  QEMU 1.3.50 monitor - type 'help' for more information
  (qemu) info numa
  1 nodes
  node 0 cpus: 0
  node 0 size: 1000 MB
  (qemu)

This changes the code to nove the pointer only if ',' is found.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

2013-02-04 14:38:33 -06:00

audio

audio: Replace non-portable asprintf in debug code by g_strdup_printf

2013-01-16 12:03:26 -06:00

backends

Make all static TypeInfos const

2013-01-10 15:11:53 -06:00

block

block/raw-posix: Build fix for O_ASYNC

2013-02-01 15:11:12 +01:00

bsd-user

linux-user: bsd-user: Don't reset X86CPU twice

2013-02-01 01:35:43 +01:00

default-configs

Add TEWS TPCI200 IndustryPack emulation

2013-01-14 13:26:12 -06:00

disas

build: remove universal-obj-y

2013-01-26 13:15:35 +00:00

docs

docs: document virtio-balloon stats

2013-01-25 10:49:46 -02:00

fpu

softfloat: Handle float_muladd_negate_c when product is zero

2013-01-26 13:22:09 +00:00

fsdev

virtfs-proxy-helper: Fix unchecked strdup() by conv. to g_strdup()

2013-01-30 11:14:46 +01:00

gdb-xml

…

qdev: drop extra references at creation time

2013-02-01 15:53:11 -06:00

include

cutils: unsigned int parsing functions

2013-02-04 14:38:33 -06:00

ldscripts

build: create ldscripts/

2012-12-19 08:29:06 +01:00

libcacard

libcacard: Fix unchecked strdup() by converting to g_strdup()

2013-01-30 11:14:46 +01:00

linux-headers

Update Linux kernel headers

2013-01-18 19:06:57 +01:00

linux-user

cpu: do not use object_delete

2013-02-01 15:53:11 -06:00

net

tap: unbreak -netdev tap,fd=X

2013-02-01 18:05:30 -06:00

pc-bios

seabios: update to 1.7.2 release

2013-01-21 09:17:16 +01:00

pixman @ 97336fad32

qapi: move include files to include/qobject/

2012-12-19 08:31:31 +01:00

qapi

qapi: Fix unchecked strdup() by converting to g_strdup()

2013-01-30 11:14:46 +01:00

qga

qemu-ga: Fix unchecked strdup() by converting to g_strdup()

2013-01-30 11:14:46 +01:00

QMP

qmp: add pull_event function

2012-10-24 10:26:22 +02:00

qobject

build: move qobject files to qobject/ and libqemuutil.a

2013-01-12 18:42:50 +01:00

qom

qom: remove object_delete

2013-02-01 15:53:11 -06:00

roms

seabios: update to 1.7.2 release

2013-01-21 09:17:16 +01:00

scripts

Merge remote-tracking branch 'qemu-kvm/uq/master' into staging

2013-01-29 16:57:41 -06:00

slirp

g_strdup(NULL) returns NULL; simplify

2013-01-30 11:14:46 +01:00

stubs

stubs: fully replace qemu-tool.c and qemu-user.c

2013-01-12 17:19:08 +01:00

sysconfigs/target

Eliminate cpus-x86_64.conf file

2012-09-21 15:12:58 +02:00

target-alpha

target-alpha: Catch attempt to instantiate abstract type in cpu_init()

2013-01-27 23:33:34 +01:00

target-arm

target-arm: Rename CPU types

2013-01-30 16:03:57 +00:00

target-cris

target-cris: Build fix for debug output

2013-02-04 16:12:57 +01:00

target-i386

cpu: do not use object_delete

2013-02-01 15:53:11 -06:00

target-lm32

cpu: Move cpu_index field to CPUState

2013-01-15 04:09:13 +01:00

target-m68k

target-m68k: Rename CPU subtypes

2013-02-01 01:35:22 +01:00

target-microblaze

target-microblaze: Mark as unmigratable

2013-02-01 01:35:21 +01:00

target-mips

target-mips: enable access to DSP ASE if implemented

2013-01-31 23:42:03 +01:00

target-openrisc

target-openrisc: Rename CPU subtypes

2013-02-01 01:35:43 +01:00

target-ppc

cpu: do not use object_delete

2013-02-01 15:53:11 -06:00

target-s390x

Merge remote-tracking branch 'agraf/s390-for-upstream' into staging

2013-02-01 09:06:23 -06:00

target-sh4

target-sh4: Mark as unmigratable

2013-02-01 01:35:22 +01:00

target-sparc

cpu: do not use object_delete

2013-02-01 15:53:11 -06:00

target-unicore32

target-unicore32: Rename CPU subtypes

2013-02-01 01:35:43 +01:00

target-xtensa

target-xtensa: Mark as unmigratable

2013-02-01 01:35:21 +01:00

tcg

tcg/target-arm: Add missing parens to assertions

2013-01-19 10:27:45 +00:00

tests

cutils: unsigned int parsing functions

2013-02-04 14:38:33 -06:00

trace

Makefile: clean timestamp generation rule

2013-01-30 01:31:08 +02:00

cocoa: Replace non-portable asprintf() by g_strdup_printf()

2013-01-31 22:27:00 +01:00

util

cutils: unsigned int parsing functions

2013-02-04 14:38:33 -06:00

.exrc

qemu: add .exrc

2012-09-07 09:02:44 +03:00

.gitignore

Add libcacard/trace/generated-tracers.c to .gitignore

2013-01-15 10:34:54 +01:00

.gitmodules

pixman: add submodule

2012-11-01 13:10:06 +01:00

.mailmap

Add a .mailmap to map pre-git-conversion authors to friendly names

2011-12-12 17:06:21 -06:00

aio-posix.c

aio: Fix return value of aio_poll()

2013-01-17 10:51:42 +01:00

aio-win32.c

aio: Fix return value of aio_poll()

2013-01-17 10:51:42 +01:00

arch_init.c

Allow XBZRLE decoding without enabling the capability

2013-02-01 08:32:21 +01:00

async.c

misc: move include files to include/qemu/

2012-12-19 08:32:39 +01:00

balloon.c

softmmu: move include files to include/sysemu/

2012-12-19 08:32:45 +01:00

block-migration.c

block: allow customizing the granularity of the dirty bitmap

2013-01-25 18:18:34 +01:00

block.c

block: Fix is_allocated_above with resized files

2013-02-01 14:58:28 +01:00

blockdev-nbd.c

softmmu: move include files to include/sysemu/

2012-12-19 08:32:45 +01:00

blockdev.c

Merge remote-tracking branch 'kwolf/for-anthony' into staging

2013-01-28 14:46:45 -06:00

blockjob.c

misc: move include files to include/qemu/

2012-12-19 08:32:39 +01:00

bt-host.c

softmmu: move remaining include files to include/ subdirectories

2012-12-19 08:32:46 +01:00

bt-vhci.c

softmmu: move remaining include files to include/ subdirectories

2012-12-19 08:32:46 +01:00

Changelog

fix some common typos

2012-05-14 07:27:24 +02:00

cmd.c

misc: move include files to include/qemu/

2012-12-19 08:32:39 +01:00

cmd.h

…

CODING_STYLE

Replace Qemu by QEMU in internal documentation

2012-04-07 13:58:25 +00:00

configure

configure: Keep -Werror enabled for Release Candidates

2013-02-01 10:43:20 -06:00

COPYING

…

COPYING.LIB

…

coroutine-gthread.c

block: move include files to include/block/

2012-12-19 08:31:31 +01:00

coroutine-sigaltstack.c

block: move include files to include/block/

2012-12-19 08:31:31 +01:00

coroutine-ucontext.c

gcc: rename CONFIG_PRAGMA_DISABLE_UNUSED_BUT_SET to CONFIG_PRAGMA_DIAGNOSTIC_AVAILABLE

2013-01-12 12:42:53 +00:00

coroutine-win32.c

block: move include files to include/block/

2012-12-19 08:31:31 +01:00

cpu-exec.c

softmmu: move include files to include/sysemu/

2012-12-19 08:32:45 +01:00

cpus.c

kvm: Pass CPUState to kvm_on_sigbus_vcpu()

2013-01-28 16:57:56 +01:00

cputlb.c

exec: move include files to include/exec/

2012-12-19 08:31:31 +01:00

device_tree.c

softmmu: move include files to include/sysemu/

2012-12-19 08:32:45 +01:00

disas.c

monitor: move include files to include/monitor/

2012-12-19 08:31:32 +01:00

dma-helpers.c

softmmu: move include files to include/sysemu/

2012-12-19 08:32:45 +01:00

dump-stub.c

softmmu: move include files to include/sysemu/

2012-12-19 08:32:45 +01:00

dump.c

exec: change RAM list to a TAILQ

2012-12-20 23:08:47 +01:00

exec.c

Replace non-portable asprintf by g_strdup_printf

2013-01-19 10:24:43 +00:00

gdbstub.c

cpu: Move cpu_index field to CPUState

2013-01-15 04:09:13 +01:00

HACKING

HACKING: List areas where we may rely on impdef C behaviour

2012-12-08 14:27:40 +00:00

hmp-commands.hx

QAPI: Introduce memchar-read QMP command

2013-01-25 11:46:50 -02:00

hmp.c

Fix error message in migrate_set_capability HMP command

2013-02-01 08:32:21 +01:00

hmp.h

QAPI: Introduce memchar-read QMP command

2013-01-25 11:46:50 -02:00

iohandler.c

misc: move include files to include/qemu/

2012-12-19 08:32:39 +01:00

ioport.c

exec: move include files to include/exec/

2012-12-19 08:31:31 +01:00

kvm-all.c

kvm: Pass CPUState to kvm_on_sigbus_vcpu()

2013-01-28 16:57:56 +01:00

kvm-stub.c

kvm: Pass CPUState to kvm_on_sigbus_vcpu()

2013-01-28 16:57:56 +01:00

LICENSE

LICENSE: There is no libqemu.a anymore

2011-12-09 11:25:22 +00:00

main-loop.c

Check return values from g_poll and select

2013-01-09 11:03:05 -06:00

MAINTAINERS

prep: Move PReP machine to hw/ppc/

2013-01-30 10:42:29 +01:00

Makefile

build: remove *.lo, *.a, *.la files from all subdirectories on make clean

2013-01-26 13:30:00 +00:00

Makefile.objs

Move XBZRLE encoding code to a separate file to allow testing

2013-02-01 08:32:20 +01:00

Makefile.target

build: remove universal-obj-y

2013-01-26 13:15:35 +00:00

memory_mapping-stub.c

softmmu: move include files to include/sysemu/

2012-12-19 08:32:45 +01:00

memory_mapping.c

exec: change RAM list to a TAILQ

2012-12-20 23:08:47 +01:00

memory.c

bitops: unify bitops_ffsl with the one in host-utils.h, call it bitops_ctzl

2013-02-02 20:16:00 +00:00

migration-exec.c

migration: make writes blocking

2012-12-20 23:09:25 +01:00

migration-fd.c

migration: make writes blocking

2012-12-20 23:09:25 +01:00

migration-tcp.c

migration: make writes blocking

2012-12-20 23:09:25 +01:00

migration-unix.c

migration: make writes blocking

2012-12-20 23:09:25 +01:00

migration.c

migration: remove argument to qemu_savevm_state_cancel

2013-01-17 13:54:52 +01:00

monitor.c

HMP: add sub command table to info

2013-01-17 10:24:52 -02:00

nbd.c

misc: move include files to include/qemu/

2012-12-19 08:32:39 +01:00

os-posix.c

softmmu: move include files to include/sysemu/

2012-12-19 08:32:45 +01:00

os-win32.c

softmmu: move include files to include/sysemu/

2012-12-19 08:32:45 +01:00

page_cache.c

migration: move include files to include/migration/

2012-12-19 08:31:32 +01:00

qapi-schema-test.json

qapi: add struct-errors test case to test-qmp-output-visitor

2012-03-27 09:11:00 -03:00

qapi-schema.json

tap: multiqueue support

2013-02-01 11:03:02 -06:00

qdict-test-data.txt

…

qemu-bridge-helper.c

misc: move include files to include/qemu/

2012-12-19 08:32:39 +01:00

qemu-char.c

Merge remote-tracking branch 'luiz/queue/qmp' into staging

2013-01-28 14:41:25 -06:00

qemu-coroutine-io.c

misc: move include files to include/qemu/

2012-12-19 08:32:39 +01:00

qemu-coroutine-lock.c

misc: move include files to include/qemu/

2012-12-19 08:32:39 +01:00

qemu-coroutine-sleep.c

misc: move include files to include/qemu/

2012-12-19 08:32:39 +01:00

qemu-coroutine.c

block: move include files to include/block/

2012-12-19 08:31:31 +01:00

qemu-doc.texi

Documentation: Update image format information

2012-11-30 11:33:24 +01:00

qemu-img-cmds.hx

qemu-img: document 'info --backing-chain'

2012-10-24 10:26:19 +02:00

qemu-img.c

qemu-img: report size overflow error message

2013-01-02 16:08:56 +01:00

qemu-img.texi

Documentation: Update image format information

2012-11-30 11:33:24 +01:00

qemu-io.c

misc: move include files to include/qemu/

2012-12-19 08:32:39 +01:00

qemu-log.c

qemu-log: Plug trivial memory leak in cpu_set_log_filename()

2013-01-30 11:14:46 +01:00

qemu-nbd.c

block: move include files to include/block/

2012-12-19 08:31:31 +01:00

qemu-nbd.texi

Replace Qemu by QEMU in user visible documentation

2012-04-07 13:58:06 +00:00

qemu-options-wrapper.h

vl.c: In qemu -h output, only print options for the arch we are running as

2011-12-19 10:27:33 -06:00

qemu-options.h

vl.c: Move option generation logic into a wrapper file

2011-12-19 10:27:33 -06:00

qemu-options.hx

qemu-char: Add new char backend CirMemCharDriver

2013-01-25 11:23:06 -02:00

qemu-seccomp.c

softmmu: move include files to include/sysemu/

2012-12-19 08:32:45 +01:00

qemu-tech.texi

qemu-tech.texi: update implemented xtensa features list

2012-11-29 13:00:52 -06:00

qemu-timer.c

softmmu: move include files to include/sysemu/

2012-12-19 08:32:45 +01:00

qemu.sasl

…

qmp-commands.hx

Fix example for query-migrate-capabilities

2013-02-01 08:32:21 +01:00

qmp.c

softmmu: move remaining include files to include/ subdirectories

2012-12-19 08:32:46 +01:00

qtest.c

accel: change {xen, kvm, tcg, qtest}_allowed from int to bool

2013-02-01 15:08:02 -06:00

readline.c

readline: Fix unchecked strdup() by converting to g_strdup()

2013-01-30 11:14:46 +01:00

README

Update README

2011-12-11 17:50:43 -06:00

rules.mak

rules/mak: make clean should blow away timestamp files

2013-01-30 01:31:08 +02:00

savevm.c

net: introduce qemu_get_queue()

2013-02-01 11:02:55 -06:00

spice-qemu-char.c

Merge remote-tracking branch 'bonzini/header-dirs' into staging

2012-12-19 17:15:39 -06:00

tcg-runtime.c

…

tci.c

exec: move include files to include/exec/

2012-12-19 08:31:31 +01:00

thread-pool.c

misc: move include files to include/qemu/

2012-12-19 08:32:39 +01:00

thunk.c

exec: move include files to include/exec/

2012-12-19 08:31:31 +01:00

TODO

…

trace-events

s390: Add new channel I/O based virtio transport.

2013-01-29 21:50:04 +01:00

translate-all.c

translate-all.c: Use tb1->phys_hash_next directly in tb_remove

2012-12-22 12:06:24 +00:00

translate-all.h

exec: move TB handling to translate-all.c

2012-12-16 08:28:41 +00:00

user-exec.c

Merge remote-tracking branch 'bonzini/header-dirs' into staging

2012-12-19 17:15:39 -06:00

VERSION

Update version for 1.4.0-rc0

2013-02-01 18:05:30 -06:00

version.rc

…

vl.c

vl.c: Fix off-by-one bug when handling "-numa node" argument

2013-02-04 14:38:33 -06:00

xbzrle.c

Move XBZRLE encoding code to a separate file to allow testing

2013-02-01 08:32:20 +01:00

xen-all.c

xen: Simplify halting of first CPU

2013-01-15 04:09:14 +01:00

xen-mapcache.c

softmmu: move include files to include/sysemu/

2012-12-19 08:32:45 +01:00

xen-stub.c

exec: move include files to include/exec/

2012-12-19 08:31:31 +01:00

README

Read the documentation in qemu-doc.html or on http://wiki.qemu.org

- QEMU team

Languages

C 90.3%

Dylan 2.5%

Python 2.1%

C++ 2%

Shell 1.7%

Other 1.4%