The USB UHCI and EHCI drivers were converted some time ago to use the pci_dma_*() helper functions. However, this conversion was not complete because in some places both these drivers do DMA via the usb_packet_map() function in usb-libhw.c. That function directly used cpu_physical_memory_map(). Now that the sglist code uses DMA wrappers properly, we can convert the functions in usb-libhw.c, thus conpleting the conversion of UHCI and EHCI to use the DMA wrappers. Note that usb_packet_map() invokes dma_memory_map() with a NULL invalidate callback function. When IOMMU support is added, this will mean that usb_packet_map() and the corresponding usb_packet_unmap() must be called in close proximity without dropping the qemu device lock - otherwise the guest might invalidate IOMMU mappings while they are still in use by the device code. Signed-off-by: David Gibson <david@gibson.dropbear.id.au> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
		
			
				
	
	
		
			65 lines
		
	
	
		
			2.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			65 lines
		
	
	
		
			2.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * QEMU USB emulation, libhw bits.
 | 
						|
 *
 | 
						|
 * Permission is hereby granted, free of charge, to any person obtaining a copy
 | 
						|
 * of this software and associated documentation files (the "Software"), to deal
 | 
						|
 * in the Software without restriction, including without limitation the rights
 | 
						|
 * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
 | 
						|
 * copies of the Software, and to permit persons to whom the Software is
 | 
						|
 * furnished to do so, subject to the following conditions:
 | 
						|
 *
 | 
						|
 * The above copyright notice and this permission notice shall be included in
 | 
						|
 * all copies or substantial portions of the Software.
 | 
						|
 *
 | 
						|
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 | 
						|
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 | 
						|
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
 | 
						|
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 | 
						|
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 | 
						|
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 | 
						|
 * THE SOFTWARE.
 | 
						|
 */
 | 
						|
#include "qemu-common.h"
 | 
						|
#include "cpu-common.h"
 | 
						|
#include "hw/usb.h"
 | 
						|
#include "dma.h"
 | 
						|
 | 
						|
int usb_packet_map(USBPacket *p, QEMUSGList *sgl)
 | 
						|
{
 | 
						|
    DMADirection dir = (p->pid == USB_TOKEN_IN) ?
 | 
						|
        DMA_DIRECTION_FROM_DEVICE : DMA_DIRECTION_TO_DEVICE;
 | 
						|
    dma_addr_t len;
 | 
						|
    void *mem;
 | 
						|
    int i;
 | 
						|
 | 
						|
    for (i = 0; i < sgl->nsg; i++) {
 | 
						|
        len = sgl->sg[i].len;
 | 
						|
        mem = dma_memory_map(sgl->dma, sgl->sg[i].base, &len, dir);
 | 
						|
        if (!mem) {
 | 
						|
            goto err;
 | 
						|
        }
 | 
						|
        qemu_iovec_add(&p->iov, mem, len);
 | 
						|
        if (len != sgl->sg[i].len) {
 | 
						|
            goto err;
 | 
						|
        }
 | 
						|
    }
 | 
						|
    return 0;
 | 
						|
 | 
						|
err:
 | 
						|
    usb_packet_unmap(p, sgl);
 | 
						|
    return -1;
 | 
						|
}
 | 
						|
 | 
						|
void usb_packet_unmap(USBPacket *p, QEMUSGList *sgl)
 | 
						|
{
 | 
						|
    DMADirection dir = (p->pid == USB_TOKEN_IN) ?
 | 
						|
        DMA_DIRECTION_FROM_DEVICE : DMA_DIRECTION_TO_DEVICE;
 | 
						|
    int i;
 | 
						|
 | 
						|
    for (i = 0; i < p->iov.niov; i++) {
 | 
						|
        dma_memory_unmap(sgl->dma, p->iov.iov[i].iov_base,
 | 
						|
                         p->iov.iov[i].iov_len, dir,
 | 
						|
                         p->iov.iov[i].iov_len);
 | 
						|
    }
 | 
						|
}
 |