Now that we can safely call QOBJECT() on QObject * as well as its subtypes, we can have macros qobject_ref() / qobject_unref() that work everywhere instead of having to use QINCREF() / QDECREF() for QObject and qobject_incref() / qobject_decref() for its subtypes. The replacement is mechanical, except I broke a long line, and added a cast in monitor_qmp_cleanup_req_queue_locked(). Unlike qobject_decref(), qobject_unref() doesn't accept void *. Note that the new macros evaluate their argument exactly once, thus no need to shout them. Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Message-Id: <20180419150145.24795-4-marcandre.lureau@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> [Rebased, semantic conflict resolved, commit message improved] Signed-off-by: Markus Armbruster <armbru@redhat.com>
		
			
				
	
	
		
			211 lines
		
	
	
		
			6.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			211 lines
		
	
	
		
			6.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * QTest testcase for netfilter
 | 
						|
 *
 | 
						|
 * Copyright (c) 2015 FUJITSU LIMITED
 | 
						|
 * Author: Yang Hongyang <yanghy@cn.fujitsu.com>
 | 
						|
 *
 | 
						|
 * This work is licensed under the terms of the GNU GPL, version 2 or
 | 
						|
 * later.  See the COPYING file in the top-level directory.
 | 
						|
 */
 | 
						|
 | 
						|
#include "qemu/osdep.h"
 | 
						|
#include "libqtest.h"
 | 
						|
#include "qapi/qmp/qdict.h"
 | 
						|
 | 
						|
/* add a netfilter to a netdev and then remove it */
 | 
						|
static void add_one_netfilter(void)
 | 
						|
{
 | 
						|
    QDict *response;
 | 
						|
 | 
						|
    response = qmp("{'execute': 'object-add',"
 | 
						|
                   " 'arguments': {"
 | 
						|
                   "   'qom-type': 'filter-buffer',"
 | 
						|
                   "   'id': 'qtest-f0',"
 | 
						|
                   "   'props': {"
 | 
						|
                   "     'netdev': 'qtest-bn0',"
 | 
						|
                   "     'queue': 'rx',"
 | 
						|
                   "     'interval': 1000"
 | 
						|
                   "}}}");
 | 
						|
 | 
						|
    g_assert(response);
 | 
						|
    g_assert(!qdict_haskey(response, "error"));
 | 
						|
    qobject_unref(response);
 | 
						|
 | 
						|
    response = qmp("{'execute': 'object-del',"
 | 
						|
                   " 'arguments': {"
 | 
						|
                   "   'id': 'qtest-f0'"
 | 
						|
                   "}}");
 | 
						|
    g_assert(response);
 | 
						|
    g_assert(!qdict_haskey(response, "error"));
 | 
						|
    qobject_unref(response);
 | 
						|
}
 | 
						|
 | 
						|
/* add a netfilter to a netdev and then remove the netdev */
 | 
						|
static void remove_netdev_with_one_netfilter(void)
 | 
						|
{
 | 
						|
    QDict *response;
 | 
						|
 | 
						|
    response = qmp("{'execute': 'object-add',"
 | 
						|
                   " 'arguments': {"
 | 
						|
                   "   'qom-type': 'filter-buffer',"
 | 
						|
                   "   'id': 'qtest-f0',"
 | 
						|
                   "   'props': {"
 | 
						|
                   "     'netdev': 'qtest-bn0',"
 | 
						|
                   "     'queue': 'rx',"
 | 
						|
                   "     'interval': 1000"
 | 
						|
                   "}}}");
 | 
						|
 | 
						|
    g_assert(response);
 | 
						|
    g_assert(!qdict_haskey(response, "error"));
 | 
						|
    qobject_unref(response);
 | 
						|
 | 
						|
    response = qmp("{'execute': 'netdev_del',"
 | 
						|
                   " 'arguments': {"
 | 
						|
                   "   'id': 'qtest-bn0'"
 | 
						|
                   "}}");
 | 
						|
    g_assert(response);
 | 
						|
    g_assert(!qdict_haskey(response, "error"));
 | 
						|
    qobject_unref(response);
 | 
						|
 | 
						|
    /* add back the netdev */
 | 
						|
    response = qmp("{'execute': 'netdev_add',"
 | 
						|
                   " 'arguments': {"
 | 
						|
                   "   'type': 'user',"
 | 
						|
                   "   'id': 'qtest-bn0'"
 | 
						|
                   "}}");
 | 
						|
    g_assert(response);
 | 
						|
    g_assert(!qdict_haskey(response, "error"));
 | 
						|
    qobject_unref(response);
 | 
						|
}
 | 
						|
 | 
						|
/* add multi(2) netfilters to a netdev and then remove them */
 | 
						|
static void add_multi_netfilter(void)
 | 
						|
{
 | 
						|
    QDict *response;
 | 
						|
 | 
						|
    response = qmp("{'execute': 'object-add',"
 | 
						|
                   " 'arguments': {"
 | 
						|
                   "   'qom-type': 'filter-buffer',"
 | 
						|
                   "   'id': 'qtest-f0',"
 | 
						|
                   "   'props': {"
 | 
						|
                   "     'netdev': 'qtest-bn0',"
 | 
						|
                   "     'queue': 'rx',"
 | 
						|
                   "     'interval': 1000"
 | 
						|
                   "}}}");
 | 
						|
 | 
						|
    g_assert(response);
 | 
						|
    g_assert(!qdict_haskey(response, "error"));
 | 
						|
    qobject_unref(response);
 | 
						|
 | 
						|
    response = qmp("{'execute': 'object-add',"
 | 
						|
                   " 'arguments': {"
 | 
						|
                   "   'qom-type': 'filter-buffer',"
 | 
						|
                   "   'id': 'qtest-f1',"
 | 
						|
                   "   'props': {"
 | 
						|
                   "     'netdev': 'qtest-bn0',"
 | 
						|
                   "     'queue': 'rx',"
 | 
						|
                   "     'interval': 1000"
 | 
						|
                   "}}}");
 | 
						|
 | 
						|
    g_assert(response);
 | 
						|
    g_assert(!qdict_haskey(response, "error"));
 | 
						|
    qobject_unref(response);
 | 
						|
 | 
						|
    response = qmp("{'execute': 'object-del',"
 | 
						|
                   " 'arguments': {"
 | 
						|
                   "   'id': 'qtest-f0'"
 | 
						|
                   "}}");
 | 
						|
    g_assert(response);
 | 
						|
    g_assert(!qdict_haskey(response, "error"));
 | 
						|
    qobject_unref(response);
 | 
						|
 | 
						|
    response = qmp("{'execute': 'object-del',"
 | 
						|
                   " 'arguments': {"
 | 
						|
                   "   'id': 'qtest-f1'"
 | 
						|
                   "}}");
 | 
						|
    g_assert(response);
 | 
						|
    g_assert(!qdict_haskey(response, "error"));
 | 
						|
    qobject_unref(response);
 | 
						|
}
 | 
						|
 | 
						|
/* add multi(2) netfilters to a netdev and then remove the netdev */
 | 
						|
static void remove_netdev_with_multi_netfilter(void)
 | 
						|
{
 | 
						|
    QDict *response;
 | 
						|
 | 
						|
    response = qmp("{'execute': 'object-add',"
 | 
						|
                   " 'arguments': {"
 | 
						|
                   "   'qom-type': 'filter-buffer',"
 | 
						|
                   "   'id': 'qtest-f0',"
 | 
						|
                   "   'props': {"
 | 
						|
                   "     'netdev': 'qtest-bn0',"
 | 
						|
                   "     'queue': 'rx',"
 | 
						|
                   "     'interval': 1000"
 | 
						|
                   "}}}");
 | 
						|
 | 
						|
    g_assert(response);
 | 
						|
    g_assert(!qdict_haskey(response, "error"));
 | 
						|
    qobject_unref(response);
 | 
						|
 | 
						|
    response = qmp("{'execute': 'object-add',"
 | 
						|
                   " 'arguments': {"
 | 
						|
                   "   'qom-type': 'filter-buffer',"
 | 
						|
                   "   'id': 'qtest-f1',"
 | 
						|
                   "   'props': {"
 | 
						|
                   "     'netdev': 'qtest-bn0',"
 | 
						|
                   "     'queue': 'rx',"
 | 
						|
                   "     'interval': 1000"
 | 
						|
                   "}}}");
 | 
						|
 | 
						|
    g_assert(response);
 | 
						|
    g_assert(!qdict_haskey(response, "error"));
 | 
						|
    qobject_unref(response);
 | 
						|
 | 
						|
    response = qmp("{'execute': 'netdev_del',"
 | 
						|
                   " 'arguments': {"
 | 
						|
                   "   'id': 'qtest-bn0'"
 | 
						|
                   "}}");
 | 
						|
    g_assert(response);
 | 
						|
    g_assert(!qdict_haskey(response, "error"));
 | 
						|
    qobject_unref(response);
 | 
						|
 | 
						|
    /* add back the netdev */
 | 
						|
    response = qmp("{'execute': 'netdev_add',"
 | 
						|
                   " 'arguments': {"
 | 
						|
                   "   'type': 'user',"
 | 
						|
                   "   'id': 'qtest-bn0'"
 | 
						|
                   "}}");
 | 
						|
    g_assert(response);
 | 
						|
    g_assert(!qdict_haskey(response, "error"));
 | 
						|
    qobject_unref(response);
 | 
						|
}
 | 
						|
 | 
						|
int main(int argc, char **argv)
 | 
						|
{
 | 
						|
    int ret;
 | 
						|
    char *args;
 | 
						|
    const char *devstr = "e1000";
 | 
						|
 | 
						|
    if (g_str_equal(qtest_get_arch(), "s390x")) {
 | 
						|
        devstr = "virtio-net-ccw";
 | 
						|
    }
 | 
						|
 | 
						|
    g_test_init(&argc, &argv, NULL);
 | 
						|
    qtest_add_func("/netfilter/addremove_one", add_one_netfilter);
 | 
						|
    qtest_add_func("/netfilter/remove_netdev_one",
 | 
						|
                   remove_netdev_with_one_netfilter);
 | 
						|
    qtest_add_func("/netfilter/addremove_multi", add_multi_netfilter);
 | 
						|
    qtest_add_func("/netfilter/remove_netdev_multi",
 | 
						|
                   remove_netdev_with_multi_netfilter);
 | 
						|
 | 
						|
    args = g_strdup_printf("-netdev user,id=qtest-bn0 "
 | 
						|
                           "-device %s,netdev=qtest-bn0", devstr);
 | 
						|
    qtest_start(args);
 | 
						|
    ret = g_test_run();
 | 
						|
 | 
						|
    qtest_end();
 | 
						|
    g_free(args);
 | 
						|
 | 
						|
    return ret;
 | 
						|
}
 |